Closed Bug 1055383 Opened 7 years ago Closed 7 years ago

MP4Reader::Decode() should not return false if output EOS is not reached.

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: bwu, Assigned: bwu)

References

Details

Attachments

(1 file, 1 obsolete file)

http://dxr.mozilla.org/mozilla-central/source/content/medi/fmp4/MP4Reader.cpp?from=MP4Reader.cpp&case=true#565 
Currently MP4Reader may return false and stop playing earlier before output EOS is reached. 
As discussion with cpearce via IRC, we should replace with data.mEOS with data.mDrainComplete. Thanks for cpearce's suggestion!
Correction for link. (don't know why copy/paste miss one letter 'a' @@")
http://dxr.mozilla.org/mozilla-central/source/content/media/fmp4/MP4Reader.cpp?from=MP4Reader.cpp&case=true#565
Assignee: nobody → bwu
Changes per above comments. 
It can work well on B2G PDM (bug 941302).
Attachment #8474943 - Flags: review?(cpearce)
Blocks: 1049325
Attachment #8474943 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/10c76b62dfcc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.