nsRegistry::GetString reimplements strdup()

RESOLVED WONTFIX

Status

()

Core
XPCOM
P3
minor
RESOLVED WONTFIX
19 years ago
a year ago

People

(Reporter: Bruce Mitchener, Assigned: Suresh Duddi (gone))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
Very interesting wheel you have there.  It looks a lot like the wheel that most
of us know as PL_strdup() or nsCRT::strdup() however.

This is referring to the lines after if (err == REGERR_OK) after getting
NR_RegGetEntryString().
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M9
(Assignee)

Updated

19 years ago
Severity: normal → minor
Target Milestone: M9 → M11
(Assignee)

Comment 1

19 years ago
This strdup is using PR_Malloc. The has to free this using PR_Free. Changing
this to nsCRT will mean changing all callers.

Minor.
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 2

19 years ago
scc was (is still?) working on fixing allocation and deallocation of all char*
data in the product.  It stands to reason that any callers in this case would
need to be corrected anyway.  Is this not so?  Should this be re-opened?

Updated

10 years ago
Component: XPCOM Registry → XPCOM
QA Contact: dp → xpcom
You need to log in before you can comment on or make changes to this bug.