Closed
Bug 1055403
Opened 10 years ago
Closed 8 years ago
No effect of setting preference instantApply="false"
Categories
(Toolkit :: Preferences, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: tim.matthews7, Assigned: jaws)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release) Build ID: 20140628183822 Steps to reproduce: I have preferences for a user to input time settings. When the idea being that a particular effect should happen at a user chosen time, the preference observer is getting called for each incremental time chooser click, causing the existing timer to be replaced each time and potentially firing the resulting event if that user clicks through to 'now'. I'm aware of the instant apply in the about:config. This appears to default to 'true' (at least on my system). I can't expect my users to change a global setting for using my addon. Instead I tried to override it with the setting as documented here: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/preference#a-instantApply Though that seems to have no effect (most probably the global setting has taken precedence) Actual results: <preference instantApply="false" was set and yet the observer of the preference changing is fired instantly. Expected results: I would expect a per <preference /> instant apply setting to override the global default.
Comment 1•10 years ago
|
||
Looks like the override would work the other way around, but not like this, because it just logical-ors the value with the preference's value... :-\ See: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/preferences.xml?rev=d6e9c178000c#164 This is probably not too hard to change to actually obey setting it to "false" explicitly (and to have the attribute not being present (or any other value) default to using the global pref's value as it does now). Do you want to write up a patch to do that? :-)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(tim.matthews7)
Assignee | ||
Comment 2•8 years ago
|
||
Clearing old needinfo request due to lack of response.
Flags: needinfo?(tim.matthews7)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63354/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63354/
Attachment #8769445 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment 4•8 years ago
|
||
Comment on attachment 8769445 [details] Bug 1055403 - Allow individual prefernece elements to opt out of the preferences-wide instantApply=true. https://reviewboard.mozilla.org/r/63354/#review60316 rs=me
Attachment #8769445 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/22c88075b22c Allow individual prefernece elements to opt out of the preferences-wide instantApply=true. r=gijs
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22c88075b22c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•