Closed Bug 1055434 Opened 10 years ago Closed 9 years ago

when bluetooth file transfer failure occurs, indicator messages are generated two.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

defect
Not set
normal

Tracking

(firefox43 fixed, b2g-v2.2 affected, b2g-master verified)

VERIFIED FIXED
FxOS-S5 (21Aug)
Tracking Status
firefox43 --- fixed
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: eunsubt, Assigned: ben.tian)

Details

Attachments

(5 files, 1 obsolete file)

User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Trident/6.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.3; .NET4.0C; .NET4.0E; CNS_UA; AD_LOGON=4C47452E4E4554) Steps to reproduce: my phone pairing with other phone. my phone reboot. turn off other phone's bluetooth. send image file from my phone to other phone. transmits is failed. (It is reproduced only first once after the reboot) Actual results: "not sent" messages are generated two in the indicator. Expected results: "not sent" messages are generated one in the indicator.
qawanted to confirm whether this bug occurs on Aries/Flame with the latest m-c.
Keywords: qawanted
This bug can be repro on latest Flame KK v2.2&2.5 and Aries KK v2.5 by the STR in comment 0. Actual results: The fail messages "File transfer cancelled" on Flame 2.5 and Areis v2.5 ("File could not be sent" on Flame v2.2) are generated two in the indicator. See attachments: Flame_kk_v2.5.3gp ,logcat_before_restart.txt and logcat0756_after_restart.txt Reproduce rate: 10/10 Device: Flame KK 2.2 (Affected) Build ID 20150813032504 Gaia Revision 102f1299e9eafe3760e1deb44d556b5c4f36b5af Gaia Date 2015-08-06 20:46:56 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9295034c0ee3 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150813.065103 Firmware Date Thu Aug 13 06:51:14 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Flame KK 2.5 (Affected) Build ID 20150813150207 Gaia Revision acfaa3957e65d52a0af2185149628a520edcc7e2 Gaia Date 2015-08-13 12:34:28 Gecko Revision https://hg.mozilla.org/mozilla- central/rev/cdf53a4dee219aabec7462888875bac08b093edc Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150813.184539 Firmware Date Thu Aug 13 18:45:52 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5(Affected) Build ID 20150814002719 Gaia Revision 39b121515ab8a8c3ea07f26d3ba1dd792e90217c Gaia Date 2015-08-13 18:25:42 Gecko Revision https://hg.mozilla.org/mozilla- central/rev/4e883591bb5dff021c108d3e30198a99547eed1e Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150813.235024 Firmware Date Thu Aug 13 23:50:32 UTC 2015 Bootloader s1
QA Whiteboard: [MGSEI-Triage+]
Keywords: qawanted
The cause is that gecko emits duplicate system message for the sending failure. The extra system message should only be emitted when there's an ongoing blob (current blob) to send, but in this bug's case OPP manager receives |OnSocketDisconnect| before assigning current blob. We expected |OnSocketConnectError| before but it's not the case on the latest bluedroid. The patch emits current blob's sending failure only when it's assigned.
Assignee: nobody → btian
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8648654 - Flags: review?(shuang)
Comment on attachment 8648654 [details] [diff] [review] Patch 1 (v1): Do not inform gaia of current blob's sending failure before assigning it Review of attachment 8648654 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp @@ +1555,4 @@ > DeleteReceivedFile(); > + FileTransferComplete(); > + } else { > + // Inform gaia of current blob's sending failure Inform gaia of current blob transfer failure.
Attachment #8648654 - Flags: review?(shuang) → review+
Revise based on reviewer's comment.
Attachment #8648654 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. Actual results: The prompt "File transfer cancelled" is generated one in the indicator after reboot. See attachment: verified_FlameKK_v2.5.3gp Reproduce rate: 0/10 Device: Flame KK 2.5 (Pass) Build ID 20150820150207 Gaia Revision c6705f739fb605031eb2a0b943ba55c64bee5a03 Gaia Date 2015-08-20 14:36:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/095988abdc560bf8ba07a94a425c6922a3e9bfd6 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150820.183055 Firmware Date Thu Aug 20 18:31:07 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5(Pass) Build ID 20150820204657 Gaia Revision c6705f739fb605031eb2a0b943ba55c64bee5a03 Gaia Date 2015-08-20 14:36:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/095988abdc560bf8ba07a94a425c6922a3e9bfd6 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150820.200928 Firmware Date Thu Aug 20 20:09:36 UTC 2015 Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: