1055457 - Dynamic switch BootAnimation backend

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Vendcom, defect, P1)

Description

[Chiajung Hung [:chiajung]]

This issue is a follow up for Bug 103218.
In bug 103218, a generic solution of BootAnimation for most devices is provided, but it makes the BootAnimation stops earlier than before.

This bug tends to make BootAnimation better by switch BootAnimation to GL render dynamically.

Comment 1

[Chiajung Hung [:chiajung]]

It seems this would be a huge change to go, as CompositorThread uses base::Thread, libdisplay can not use it directly. We may need make the chromium ipc code a stand alone library, and make others link to it.

Comment 2

[Chiajung Hung [:chiajung]]

Attachment: WIP

With this patch, the BootAnimation plays longer, and I think the GL part maybe redundant, since both Dolphin/Flame shows only 1 frame from GL...That means we update first frame very soon after GL init.

Another small problem of this patch is that GL frame is upside down and not central positioned, which should be easy to fix.

Comment 3

[Chiajung Hung [:chiajung]]

Peter, Michael

Do you think we need the last frame from GL? If yes, I can fix the render problem mentioned in comment 2. Otherwise, I can remove those parts and start to clean up the patch for review.

Comment 4

[Peter Chang[:pchang]]

(In reply to Chiajung Hung [:chiajung] from comment #3)
> Peter, Michael
> 
> Do you think we need the last frame from GL? If yes, I can fix the render
> problem mentioned in comment 2. Otherwise, I can remove those parts and
> start to clean up the patch for review.

Could you confirm there is no black frame between boot animation and the first frame from compositor first?

Comment 5

[Chiajung Hung [:chiajung]]

Attachment: WIP v2

This version removes all black frame in previous version, I am going to fixing the up side down problem.

Comment 6

[Chiajung Hung [:chiajung]]

Attachment: WIP V3, part 1

Comment 7

[Chiajung Hung [:chiajung]]

Attachment: WIP V3, part 2

WIP V3 fixes a deadlock in BootAnimation, which make GLRenderer go further, the final problem of this version would be a flashing black screen right after BootAnimation's stop.

Comment 8

[Chiajung Hung [:chiajung]]

Attachment: WIP V4

WIP v3 shows a black screen then jump back 1 frame and stuck there. Where black frame is comes from:
http://dxr.mozilla.org/mozilla-central/source/widget/gonk/HwcComposer2D.cpp#689

And those freezed frame is from next swap (the content draws nothing and triggers swap buffer once).

We use a stand alone buffer before, so we did not observe the black frame before. And because we stopped the BootAnimation when UpdateFBSurface/SwapBuffers before, we did not observe the freezed frame.

This patch fix these problems by stop animation at the same point of time, and clear up the old frame while stop animation.

Comment 9

[Josh Cheng [:josh]]

Hi Chiajung,
This bug is also reported by partner per bug 1110566. Do you think your patch can fix this issue in 2.0M? Thanks!

Comment 10

[Peter Chang[:pchang]]

(In reply to Josh Cheng [:josh] from comment #9)
> Hi Chiajung,
> This bug is also reported by partner per bug 1110566. Do you think your
> patch can fix this issue in 2.0M? Thanks!

Josh, I think user still can sense the black frame as mentioned in comment 8 after applying the WIP v4 attachment 8486239 [details] [diff] [review]. And it is not easy to fix the black frame. Is it a hard blocker for 2.0M?

Comment 11

[Josh Cheng [:josh]]

Hi Peter,
Thanks for the reply. Partner raise concern about it but not a blocker. If this is still not able to fix the black frame, I will communicate this to partner as this is current limitation. 
Thanks!

Comment 12

[Chiajung Hung [:chiajung]]

Clear my ni based on comment 10 and 11.

Comment 14

[BMO Automation]

Firefox OS is not being worked on