1055498 - [Collection] [Refactor] Clean up create_collection.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

The code changed a lot during v2.0 development.
There is duplication we need to remove, wrong use of Promises we need to fix and general clean up to do.

Comment 1

[Amir Nissim (:amirn)]

Attachment: Pull Request

Hi Kevin, can you take this quick review?
I mostly moved stuff around. Also fixed wrong usage of Promises and some styling.
Thanks!

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8475110 [details] [review]
Pull Request

It looks like collection_offline_test.js is failing on this pull request. Can you try running this locally to verify if it's broken or not?

Comment 3

[Amir Nissim (:amirn)]

Comment on attachment 8475110 [details] [review]
Pull Request

(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8475110 [details] [review]
> Pull Request
> 
> It looks like collection_offline_test.js is failing on this pull request.
> Can you try running this locally to verify if it's broken or not?

Fixed the test. Sorry about that ;)

(although, it will no longer be valid for bug 1033641. I will comment there)

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8475110 [details] [review]
Pull Request

Seems good to me, thanks for cleaning it up!

Comment 5

[Amir Nissim (:amirn)]

master: https://github.com/mozilla-b2g/gaia/commit/a9627e3