Closed Bug 1055520 Opened 7 years ago Closed 7 years ago

update to ElasticUtils 0.10

Categories

(Input Graveyard :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=dev c=backend p=1 s=input.2014q3)

We should update to ElasticUtils 0.10 for two reasons:

1. At some point, IT will hopefully update our Elasticsearch cluster to 1.0+. ElasticUtils 0.10 supports Elasticsearch 0.90 (what we're using now), 1.0 and 1.1. We need to update before they update our cluster.

2. Oh, wait--only one reason, but it's a big one.


This bug covers updating.
The changes were pretty straight-forward:

1. update ElasticUtils to v0.10

2. change instances where we're using .values_list() or .values_dict() because the shape of the results is slightly different in ElasticUtils v0.10 (all values are now lists)

3. add some code to the API to "reshape" results because we're essentially taking what's in ES and sending it back to the user, but we only want lists as values for fields that should be lists (e.g. "description_bigrams")


In a PR: https://github.com/mozilla/fjord/pull/330
Landed in master in: https://github.com/mozilla/fjord/commit/c4e8e345
Status: NEW → ASSIGNED
Fixed a bug I found on stage: https://github.com/mozilla/fjord/commit/e023fa4e

Pushed to production just now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.