Closed Bug 1055521 Opened 9 years ago Closed 9 years ago

[mozcrash] Expose log_crashes in __all__

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: jgraham, Assigned: jgraham)

Details

Attachments

(1 file)

Expose mozcrash.log_crashes for structured logging of crashes, r=ted.mielczarek
865 bytes, patch
ted
: review+
Details | Diff | Splinter Review 
So that one can import mozcrash; mozcrash.log_crashes
Comment on attachment 8475144 [details] [diff] [review]
Expose mozcrash.log_crashes for structured logging of crashes, r=ted.mielczarek

Review of attachment 8475144 [details] [diff] [review]:
-----------------------------------------------------------------

You should really mark r? on patches if you want them reviewed. :)

::: testing/mozbase/mozcrash/mozcrash/mozcrash.py
@@ +3,5 @@
>  # You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  __all__ = ['check_for_crashes',
> +           'check_for_java_exception',
> +           'log_crashes']

nit: can you stick the opening and closing brackets on their own lines?
Attachment #8475144 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/05196e881908
Assignee: nobody → james
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.