1055537 - Provide a way to output the default log format to file

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently if no other handler is logging to stdout, a custom MarionetteTbplFormatter handler is created. In order to start submitting this to Treeherder when we're not running on buildbot we need to output this format to disk.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Chris: Is there a way to extend the log formatters so we can have additional command line arguments for custom formatters, or even allow us to override the 'tbpl' formatter in this case?

Comment 2

[Chris Manchester (limited bugmail, email directly)]

The restriction imposed by using the one-off formatter is becoming a common issue, so I came up with bug 1055070 to address these sorts of issues. However there might be a different solution available here.

The MarionetteTbplFormatter's sole purpose is to format exception stacks to look like the output from before the conversion to structured logging, in particular so the exception message shows up on the first line instead of the last (to make failures starrable). So, short of the fix in bug 1055070, we could re-format these stacks in the runner before ever logging them to make the formatter go away. On the other hand, is the requirement to comply with the old output format relaxed in this context? If so adding --log-tbpl=<file> may be sufficient.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

After some discussion in bug 1055070 we decided to solve the requirement for exceptions in a better way -- the MarionetteTbplFormatter can go away as soon as we do.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This was fixed when the dependent bug was fixed.