Closed
Bug 1055541
Opened 10 years ago
Closed 10 years ago
Build failure on VS2013 with --enable-warnings-as-errors due to: Warning C4996: 'GetVersionExW': was declared deprecated in windows_version.cc
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
|
856 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8475170 -
Flags: review?(smichaud)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8475170 [details] [diff] [review] Fix build failure on VS2013 with --enable-warnings-as-errors due to Warning C4996 I'm not really an appropriate reviewer for this patch. And just now I realized I should have asked someone else to review the MSVC-related changes in the patch for bug 1052033. Ehsan, you reviewed the patch for bug 556886, which disabled an MSVC-specific warning. Could you also review this patch, and look at the MSVC-specific changes that I already (and inadvertently) r+ed for bug 1052033?
Attachment #8475170 -
Flags: review?(smichaud) → review?(ehsan)
|
||
Updated•10 years ago
|
Attachment #8475170 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/587ef44dcc8e
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/587ef44dcc8e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•