1055552 - Update MDN commit & review policies

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: General, defect)

Description

[Luke Crouch [:groovecoder]]

Based on notes from email threads and meetings, we're starting initial changes to our commit & review policies:

1. All commit messages must start with "[fix ]bug NNNNNNN"
 * Reason: Make it easy for someone to consume the commit log and reach originating requests for all changes
 * Exceptions: "Merge" and "Revert" commits
 * Notes: Pull requests with multiple commits should squash/re-word commits together such that each commit message contains a bug number

2. MDN module owner or peers[2] must review and merge all pull requests.
 * Reason: Owner and peers are and accountable for the quality of MDN code changes
 * Exceptions: Owners/peers may commit directly to master for critical security/down-time fixes; they must file a bug for follow-up review.
 * Notes: Luke will give peer status to all current MDN staff developers.

3. MDN reviewers must verify sufficient test coverage on all changes - either by new or existing tests
 * Reason: Automated tests reduce human error involved in reviews 

We need to add these to our CONTRIBUTING.md file.

I don't expect we've got everything right on our first try, so we can use this bug for follow-up comments, discussion, and more changes.

Comment 1

[Luke Crouch [:groovecoder]]

[2] Module owners and peers: https://wiki.mozilla.org/Modules/All#MDN

Comment 2

[Luke Crouch [:groovecoder]]

Submitted https://github.com/mozilla/kuma/pull/2681 ... which follows the new policies to add the new policies. It's like a policy-ception.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0a53c181e3c63eec2999fab0b0f419926e804231
bug 1055552 - add new policies to CONTRIBUTING.md

https://github.com/mozilla/kuma/commit/735db76efdd6a2360103b1f168895ae79a7d49b4
Merge pull request #2681 from groovecoder/update-commit-policies-1055552

bug 1055552 - add new policies to CONTRIBUTING.md

Comment 4

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.