1055601 - about:home flickers on new tabs in the strip

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

I thought we had fixed that before. This issue becomes more prominent because the tab strip is always visible.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Don't flicker about:home URL when new tab is created (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8512722 [details] [diff] [review]
Don't flicker about:home URL when new tab is created (r=mcomella)

Also reduces title flickering on startup.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8512722 [details] [diff] [review]
Don't flicker about:home URL when new tab is created (r=mcomella)

Review of attachment 8512722 [details] [diff] [review]:
-----------------------------------------------------------------

Add a comment to aboutHome.dtd to keep android_strings.dtd in-sync with this. Perhaps you should also name the strings explicitly (and make a note in the comment to update the explicit string names when they're updated in the comments).

Comment 4

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8512722 [details] [diff] [review]
> Don't flicker about:home URL when new tab is created (r=mcomella)
> 
> Review of attachment 8512722 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Add a comment to aboutHome.dtd to keep android_strings.dtd in-sync with
> this. Perhaps you should also name the strings explicitly (and make a note
> in the comment to update the explicit string names when they're updated in
> the comments).

Not sure what you mean by "name the strings explicitly" here. Added the comment as suggested.

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/412049fdf1bc

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Lucas Rocha (:lucasr) from comment #4)
> Not sure what you mean by "name the strings explicitly" here.

To use the String names rather than a description of what they are, e.g. home_title and abouthome.title - one comment has this, one does not.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/412049fdf1bc