Replace MOZ_ANDROID_OMTC with MOZ_WIDGET_ANDROID

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

34 Branch
mozilla34
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It seems unnecessary to keep the MOZ_ANDROID_OMTC define around, since it should be equivalent to MOZ_WIDGET_ANDROID. Fennec doesn't work with non-OMTC.
Posted patch PatchSplinter Review
Pretty simple rename/remove

Try push at https://tbpl.mozilla.org/?tree=Try&rev=53e78883b6a1
Assignee: nobody → bugmail.mozilla
Attachment #8477533 - Flags: review?(bgirard)
Mentor: bugmail.mozilla
Comment on attachment 8477533 [details] [diff] [review]
Patch

Review of attachment 8477533 [details] [diff] [review]:
-----------------------------------------------------------------

r+ without the clobber request.

::: CLOBBER
@@ +21,5 @@
>  # Are you updating CLOBBER because you think it's needed for your WebIDL
>  # changes to stick? As of bug 928195, this shouldn't be necessary! Please
>  # don't change CLOBBER for WebIDL changes any more.
>  
> +Bug 1055605 changed a confvar/defines for Fennec and probably needs a clobber.

A change to configure.in should trigger the proper rebuild. If it doesn't this should get a build system bug IMO.
Attachment #8477533 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/0d4a39e7ee23
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.