Closed Bug 1055619 Opened 7 years ago Closed 7 years ago
[B2G][Gaia][Camera] Displays empty error message for some recording failures
If start recording fails and triggers the onError case, i.e. 08-18 19:28:27.280 1086 1130 I Gecko : [Child 1086] WARNING: Camera control API(6) failed with 0x80004005: file ../../../../B2G_HG/b2g-inbound/dom/camera/CameraControlImpl.cpp, line 375 08-18 19:28:27.280 1086 1130 I Gecko : CameraControlImpl::OnUserError : aContext='StartRecording' (6), aError=0x80004005 The error callback yields the text "GeneralFailure" as the reason but this results in an empty message being displayed to the user.
Comment on attachment 8475247 [details] [review] Gaia/camera pull request Andrew: Thanks for explaining on IRC! Conditional R+, please add a brief comment explaining that we are wrapping `onRecordingError()` in `onError()` to intentionally drop the argument.
Attachment #8475247 - Flags: review?(jdarcangelo) → review+
try: https://tbpl.mozilla.org/?rev=ecd58a43321626fa3f6c61d124c6adad50542393&tree=Gaia-Try The OS X Gip tests had a failure, but is unrelated to this change.
You need to log in before you can comment on or make changes to this bug.