Closed Bug 1055619 Opened 10 years ago Closed 10 years ago

[B2G][Gaia][Camera] Displays empty error message for some recording failures

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.4 wontfix, b2g-v2.0 affected, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S3 (29aug)
Tracking Flags:
Tracking Status
b2g-v1.4 --- wontfix
b2g-v2.0 --- affected
b2g-v2.1 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

Gaia/camera pull request
47 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
If start recording fails and triggers the onError case, i.e.

08-18 19:28:27.280  1086  1130 I Gecko   : [Child 1086] WARNING: Camera control API(6) failed with 0x80004005: file ../../../../B2G_HG/b2g-inbound/dom/camera/CameraControlImpl.cpp, line 375
08-18 19:28:27.280  1086  1130 I Gecko   : CameraControlImpl::OnUserError : aContext='StartRecording' (6), aError=0x80004005

The error callback yields the text "GeneralFailure" as the reason but this results in an empty message being displayed to the user.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → affected

        Attachment #8475247 -
        Flags: review?(jdarcangelo)

    
    

    
  
Comment on attachment 8475247 [details] [review]
Gaia/camera pull request

Andrew: Thanks for explaining on IRC! Conditional R+, please add a brief comment explaining that we are wrapping `onRecordingError()` in `onError()` to intentionally drop the argument.

        Attachment #8475247 -
        Flags: review?(jdarcangelo) → review+

    
    

    
  
try: https://tbpl.mozilla.org/?rev=ecd58a43321626fa3f6c61d124c6adad50542393&tree=Gaia-Try

The OS X Gip tests had a failure, but is unrelated to this change.

          status-b2g-v1.4:
          affected → wontfix
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/6c17bb80bd2e33968a516c29849489995c54dd7b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago

          status-b2g-v2.1:
          affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: