[B2G][Gaia][Camera] Displays empty error message for some recording failures

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia::Camera
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v1.4 wontfix, b2g-v2.0 affected, b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
If start recording fails and triggers the onError case, i.e.

08-18 19:28:27.280  1086  1130 I Gecko   : [Child 1086] WARNING: Camera control API(6) failed with 0x80004005: file ../../../../B2G_HG/b2g-inbound/dom/camera/CameraControlImpl.cpp, line 375
08-18 19:28:27.280  1086  1130 I Gecko   : CameraControlImpl::OnUserError : aContext='StartRecording' (6), aError=0x80004005

The error callback yields the text "GeneralFailure" as the reason but this results in an empty message being displayed to the user.
(Assignee)

Updated

4 years ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → affected
(Assignee)

Comment 1

4 years ago
Created attachment 8475247 [details] [review]
Gaia/camera pull request
Attachment #8475247 - Flags: review?(jdarcangelo)
Comment on attachment 8475247 [details] [review]
Gaia/camera pull request

Andrew: Thanks for explaining on IRC! Conditional R+, please add a brief comment explaining that we are wrapping `onRecordingError()` in `onError()` to intentionally drop the argument.
Attachment #8475247 - Flags: review?(jdarcangelo) → review+
(Assignee)

Comment 3

4 years ago
try: https://tbpl.mozilla.org/?rev=ecd58a43321626fa3f6c61d124c6adad50542393&tree=Gaia-Try

The OS X Gip tests had a failure, but is unrelated to this change.
status-b2g-v1.4: affected → wontfix
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/6c17bb80bd2e33968a516c29849489995c54dd7b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.