1055655 - Fix warnings turned to errors by bug 1018288 found by mingw build.

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Jacek Caban]

It wasn't found by usual builds because MSVC doesn't have those warnings. WindowsGamepad.cpp part seems like a real bug.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 8475274 [details] [diff] [review]
patch

Review of attachment 8475274 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think I can actually review the rest of these files, but they look okay to me FWIW.

::: hal/windows/WindowsGamepad.cpp
@@ +177,5 @@
>  bool
>  GetPreparsedData(HANDLE handle, nsTArray<uint8_t>& data)
>  {
>    UINT size;
> +  if (GetRawInputDeviceInfo(handle, RIDI_PREPARSEDDATA, nullptr, &size) == (UINT)-1) {

It might be nice to stick this in a constant at the top of the file, like:
const UINT kRawInputError = (UINT)-1;

Also, good job, Microsoft, putting -1 as the error return for a UINT-returning function.

Comment 2

[Jacek Caban]

Attachment: patch v1.1

Thanks for review, the attached version uses kRawInputError instead.

Jim, could you please review widget/ part?

Comment 3

[Jacek Caban]

Thanks for reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/adca749eb686

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/adca749eb686