enable spot instances for some release builders

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Good candidates are:

update verify, final verify (read-only builders)
xulrunner builders

Maybe linux builds (not l10n repacks) too - they are not in critical path and almost idempotent.
(Assignee)

Comment 1

5 years ago
Posted patch spot.diff (obsolete) — Splinter Review
Attachment #8475508 - Flags: review?(bhearsum)
Comment on attachment 8475508 [details] [diff] [review]
spot.diff

Review of attachment 8475508 [details] [diff] [review]:
-----------------------------------------------------------------

x

::: process/release.py
@@ -1060,1 @@
>                  'env': builder_env,

Partner repacks all happen on Mac anyways, but this is fine.

@@ -1439,5 @@
>              'builddir': builderPrefix('postrelease'),
>              'slavebuilddir': normalizeName(builderPrefix('postrelease'), releaseConfig['productName']),
>              'factory': postrelease_factory,
>              'env': builder_env,
> -            'nextSlave': _nextSlave_skip_spot,

I don't think this is safely re-runnable. updateSymlink could fail, and maybe the bouncer alias'?
(Assignee)

Comment 3

5 years ago
Posted patch spot2.diffSplinter Review
Attachment #8475508 - Attachment is obsolete: true
Attachment #8475508 - Flags: review?(bhearsum)
Attachment #8475942 - Flags: review?(bhearsum)
Attachment #8475942 - Flags: review?(bhearsum) → review+
buildbotcustom patch live in production
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.