1055813 - Exclude release+b2gbumper from perf regression emails

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We get emails to release+b2gbumper@m.c when perf numbers change and the b2g_bumper is one of the changesets in the range. 

We should either
* prevent release+b2gbumper from getting the emails, since there's nothing for us to do in response
* send email to all the authors of the changesets in the bump

The latter may not be appropriate for non-b2g regressions.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is where the code is to build the email list:
http://hg.mozilla.org/graphs/file/632a9d16cb0d/server/analysis/analyze_talos.py#l611

I suspect we could add a check in this for loop (http://hg.mozilla.org/graphs/file/632a9d16cb0d/server/analysis/analyze_talos.py#l618):
if author in ['[e-mail]']:
    continue

that would give us flexibility to add other email addresses as well.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [talos] Skip whitelisted address

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8476425 [details] [diff] [review]
[talos] Skip whitelisted address

Review of attachment 8476425 [details] [diff] [review]:
-----------------------------------------------------------------

::: server/analysis/analyze_talos.py
@@ +624,5 @@
>                  pusher = email.utils.parseaddr(c['pusher'])
>                  if pusher != ('', ''):
>                      pusher = email.utils.formataddr(pusher)
>  
> +                if author in ('B2G Bumper Bot <[e-mail]>',):

honestly I am not sure if this is the correct format, but we can give it a try

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8476425 [details] [diff] [review]
[talos] Skip whitelisted address

I grabbed the address from an email we received, and it matches what is in hg too.

Landed: http://hg.mozilla.org/graphs/rev/322eacb65492

Updated cruncher:~catlee/graphs from rev 217745463427 to 322eacb65492.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Followup fix for typo, http://hg.mozilla.org/graphs/rev/c63ec038ee40. Deployed.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Confirmed working.