If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

UX review for buttons on apps details page

RESOLVED FIXED

Status

Marketplace
Consumer Pages
P4
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: krupa, Assigned: chuck)

Tracking

({uiwanted})

x86
Gonk (Firefox OS)
uiwanted
Points:
---

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8475493 [details]
screenshot

steps to reproduce:
1. Load https://marketplace-feed-dev.allizom.org/app/jumping-marcelo?src=branded-editorial-element
2. Scroll down and notice the change to all the buttons
3. Compare it to https://marketplace-dev.allizom.org/app/etsy?src=featured


We have new style guides for buttons but I'd like phil to r+ these changes.

To me, the darker grey seems like things are disabled.
(Reporter)

Updated

3 years ago
Flags: needinfo?(pwalmsley)
(Reporter)

Comment 1

3 years ago
Created attachment 8475737 [details]
different shades of blue on Settings page

Updated

3 years ago
Severity: major → normal
Priority: -- → P4

Comment 2

3 years ago
The grey buttons: the lighter they get, the more disabled they look, so we'll stick with the current grey.

This different blues together are quite a quandary! Let's nix the lighter blue entirely and go with straight up blue (#4cb1ff) for all those buttons. Not enough difference visually when presented next to each other like that.
Flags: needinfo?(pwalmsley)
(Reporter)

Comment 3

3 years ago
Phil, you okay with the review stars looking like https://www.dropbox.com/s/xn2xlpdkbgvu0a5/Screenshot%202014-08-20%2011.53.10.png in the newly greyed button?
Unrelated to the button, but the line-height of the blue stars next to the byline needs to be adjusted.
https://photos-1.dropbox.com/t/0/AACZRMVQY-nz2OD5Ixx6DYeEXwjWYd9A-s2p62RKVbB3Ag/12/60118660/png/1024x768/3/1408564800/0/2/Screenshot%202014-08-20%2011.53.10.png/czSgNv3pbXyChK98rkTLgMgoFSuphGEfagLzturvO_w

Also, for the button, shouldn't we format the numbers (e.g., in English "2659" would be "2,659")? 

For measure, we do this on AMO:
http://cl.ly/image/2x0D2H3x3p2x/Screen%20Shot%202014-08-20%20at%2011.55.14%20AM.png

Comment 6

3 years ago
Krupa: Yes, I am ok with that.

cvan: Your attention detail is awesome and appreciated! That line-height does need to be adjusted and we should format the numbers properly (2,345).
Also, it seems odd that the font-size for the button text ("2659 Reviews") is smaller than that of the review body text ("very good").
Keywords: uiwanted
Assignee: nobody → pwalmsley

Comment 8

3 years ago
Realized last night that these issues have arisen from new stuff (buttons) in old layouts (app details, settings). 

So: Going to remove the light blue from the colour palette. Doesn't work. Will do a review of buttons and their text right now, mock-ups to follow.

Comment 9

3 years ago
Created attachment 8476967 [details]
buttons-tweaked.png

Pretty simple changes: drop lt blue instances and replace it with regular blue, and format numbers properly. Not much else to change here at this juncture.

Updated

3 years ago
Assignee: pwalmsley → dspasovski
(Assignee)

Updated

3 years ago
Assignee: dspasovski → charmston
(Assignee)

Comment 10

3 years ago
https://github.com/mozilla/fireplace/compare/17619e2a514d...aa1ef1a3f316
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.