1055820 - Build error due to GetVersionExW being deprecated in VS2013

Status: RESOLVED DUPLICATE of bug 1055541

(Core :: Security, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I'm getting a build error on Windows 8.1 with m-c tip and warings-as-errors on:

1:42.04 c:/Users/cpearce/src/mozilla/purple/security/sandbox/chromium/base/win/windows_version.cc(37) : error C2220: warning treated as error - no 'object' file generated
1:42.04 Warning: C4996 in c:\Users\cpearce\src\mozilla\purple\security\sandbox\chromium\base\win\windows_version.cc: 'GetVersionExW': was declared deprecated
1:42.04 c:/Users/cpearce/src/mozilla/purple/security/sandbox/chromium/base/win/windows_version.cc(37) : warning C4996: 'GetVersionExW': was declared deprecated
1:42.04 C:\Program Files (x86)\Windows Kits\8.1\Include\um\sysinfoapi.h(442) : see declaration of 'GetVersionExW'

This is similar to Bug 892859; GetVersionExW is deprecated with the Win8.1 SDK installed, I think I have that because it comes with Visual Studio 2013 which I have installed too.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: 1055820-sandbox-wae.patch

Suppress warning 4996 in Windows sandbox.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

We should not be modifying code that came from upstream.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

OK. How should we prevent this error? Disable warnings-as-errors on this directory? Or can we add a compile time option on Windows to disable this warning?

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Chris Pearce (:cpearce) from comment #3)
> OK. How should we prevent this error? Disable warnings-as-errors on this
> directory? Or can we add a compile time option on Windows to disable this
> warning?

The latter.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8475507 [details] [diff] [review]
1055820-sandbox-wae.patch

Review of attachment 8475507 [details] [diff] [review]:
-----------------------------------------------------------------

Dropping review per above.