Closed Bug 1055858 Opened 7 years ago Closed 7 years ago

Add new parameter - releaseBuildOnBetaChannel - to ship it


(Release Engineering :: Applications: Shipit (backend), defect, P2)



(Not tracked)



(Reporter: nthomas, Assigned: nthomas)



(Whiteboard: [kanban:engops:] [shipit])


(1 file, 1 obsolete file)

We want to put Firefox release builds on the beta channel for x.0 but not x.0.y (ie not chemspills). So we need a parameter that can
* default to true for Firefox, branch of mozilla-release, and version of x.0
* default to false otherwise

Help welcome.
Assignee: nobody → nthomas
Priority: -- → P2
Small regression from c335cd541b6309a635ba3688a23910a1be7967b4.
Attachment #8475637 - Flags: review?(bhearsum)
Comment on attachment 8475637 [details] [diff] [review]
[release-kickoff] Fix tests on HEAD

Review of attachment 8475637 [details] [diff] [review]:

Embarassingly, I totally forgot that these tests exist. Thanks for the fix, asd reminder.
Attachment #8475637 - Flags: review?(bhearsum) → review+
* adds the functionality I'm looking for, tests pass (although I didn't add much), UI works
* doesn't set any defaults based on the criteria in comment #0, as I didn't wrap my head suggestions and no code to crib off (eg dashboard check)

* has a migration script, but upgrade fails if I set nullable=False like on other booleans, at least with sqlite3. Downgrade fails with
sqlalchemy.exc.IntegrityError: (IntegrityError) CHECK constraint failed: firefox_release u'INSERT INTO firefox_release SELECT name ,submitter ,"submittedAt" ,version ,"buildNumber" ,branch ,"mozillaRevision" ,"l10nChangesets" ,"dashboardCheck" ,ready ,complete ,status ,"mozillaRelbranch" ,"enUSPlatforms" ,comment ,partials ,"promptWaitTime" from migration_tmp' ()
Attachment #8475666 - Flags: feedback?(bhearsum)
Attachment #8475666 - Attachment description: [release-kickoff] All most there wip → [release-kickoff] Almost there WIP
The migration script is hand crafted, which may be the problem.
Summary: Add new parameter - releaseBuildonBetaChannel - to ship it → Add new parameter - releaseBuildOnBetaChannel - to ship it
Ooh, bug 1055524 shows me how to do the default setting on the checkbox.
Comment on attachment 8475666 [details] [diff] [review]
[release-kickoff] Almost there WIP

Review of attachment 8475666 [details] [diff] [review]:

We talked about this on Vidyo, but for posterity: this all looks fine to me, but a more clear name than "release build on beta channel" (possibly a verb) would be nice.
Attachment #8475666 - Flags: feedback?(bhearsum) → feedback+
Comment on attachment 8475637 [details] [diff] [review]
[release-kickoff] Fix tests on HEAD

Obsoleting in favour of attachment 8475972 [details] [diff] [review], which sets values in the releases and checks for them.
Attachment #8475637 - Attachment is obsolete: true
Whiteboard: [shipit] → [kanban:engops:] [shipit]
Whiteboard: [kanban:engops:] [shipit] → [kanban:engops:] [shipit]
Whiteboard: [kanban:engops:] [shipit] → [kanban:engops:] [shipit]
Mass component change for ship it bugs.
Component: Tools → Ship It
Bug 1105485 went a different way on this, using from tools to toggle the betaChannelEnabled parameter in release-runner.
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.