Open Bug 1055892 Opened 10 years ago Updated 2 years ago

Remove unneeded parameters from nsILineIterator::GetLine

Categories

(Core :: Layout, defect)

defect

Tracking

()

People

(Reporter: seth, Unassigned)

References

Details

In bug 35168 comment 76, dbaron noticed the following issue, which we'll tackle in this bug:

nsILineIterator
===============
 * the comments for nsILineIterator::GetLine explicitly say that
   rel-pos may move things outside of the line bounds
 * The *only* user of FindFrameAt is
   nsFrame::GetNextPrevLineFromeBlockFrame
 * It looks to me like the only user of the lineBounds outparam from
   GetLine is nsFrame::RefreshSizeCache, which should probably be
   using nsBlockFrame directly instead of using the line iterator,
   and which can't have a row group frame.  (The flags param also looks
   unused.)

So:
 * we should probably file a followup on removing the rect and flags
   params from GetLine, which means converting nsFrame::RefreshSizeCache
   to access block frames directly
Summary: Remove unneeded parameters from nsILineITerator::GetLine → Remove unneeded parameters from nsILineIterator::GetLine
Depends on: 35168
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.