1055909 - Cannot build without google play services - with MOZ_NATIVE_DEVICES unset by branding

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nathan Toone [:toonetown]]

Attachment: Patch which performs the google play services check after configure.sh loads

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.78.2 (KHTML, like Gecko) Version/7.0.6 Safari/537.78.2

Steps to reproduce:

Build with customized branding - which uses a configure.sh script that unsets MOZ_NATIVE_DEVICES.  The configure step of build fails because google play service is required (but it should not be required if MOZ_NATIVE_DEVICES is unset).  This happens because the check for google play service happens before configure.sh is loaded.


Actual results:

build fails during configuration


Expected results:

The check for google play service should happen after the configure.sh script is loaded for a brand.  Attached is a patch which addresses the issue.

Comment 1

[Nick Alexander :nalexander [he/him]]

Hi Nathan, thanks for the report and the patch.  I do not feel qualified to review this, so I'm going to request feedback from a different build peer.  However, it does occur that perhaps we should be adding a configure flag like --with{out}-google-play-services or something rather than re-ordering this logic [1].  (As an aside, it's odd that you're setting this as part of branding; I expect it to be part of mozconfig.)

I think glandium is the right person to comment on whether this change is sensible, or whether we should be taking a different approach.  glandium?

[1] wesj started on something like this, but it got backed out: Bug 1033560.

Comment 2

[Nathan Toone [:toonetown]]

Yeah - the reason I put you (and west) to review was because you reviewed the lines that I was modifying.  The current android.m4 file uses checks if MOZ_NATIVE_DEVICES is set or not.  This is set in mobile/android/confvars.sh, so it's not able to be reset in a mozconfig (I agree, it would make the most sense to modify it there, probably).  I was resetting the variable value in branding because that was the only way I could find to be able to configure that value, since it was set in confvars.sh.

I am completely fine with a different approach - this was just my first shot at a solution (which did work for me, at least).  Any guidance is appreciated.

Comment 3

[Nathan Toone [:toonetown]]

Attachment: Patch which performs the google play services check after configure.sh loads

Updating with hg-formatted patch.  Carrying over review+ from glandium on original patch

Comment 4

[Nathan Toone [:toonetown]]

Attachment: Patch which performs the google play services check after configure.sh loads

Fixing email address used in patch

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/f00f95bb8900

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f00f95bb8900