1055926 - Mozmill tests don't run due to no mozinfo

Status: RESOLVED FIXED

Description

[Joshua Cranmer [:jcranmer]]

I have a simple solution to this, which is to import mozinfo and mozfile (a mozmill dependency) directly into the virtualenv from a mozbase location. This requires a buildbot config change, though. :-(

Comment 1

[Joshua Cranmer [:jcranmer]]

Created attachment 8475679 [details] [diff] [review]
Install from mozbase.

The obvious person to review this patch would be the person who's away for another 6 days. I'm going to ask Callek to review this patch if he feels comfortable doing so, but I totally understand him not being comfortable.

Another issue that is beyond my personal ability is that this changes the call to installmozmill, which at present requires a buildbot change as well:
<http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4975>. If this is going to involve a complicated buildbot change, it may be worth just spending the effort on bug 1054308 instead.

Comment 2

[Joshua Cranmer [:jcranmer]]

FWIW, the command line this would need would appear to be
python resources/installmozbuild.py MOZMILL_VIRTUALENV_DIR ../mozbase [since CWD is $TEST_UNPACK_DIR/mozmill, and mozbase is in $TEST_UNPACK_DIR/mozbase]

Comment 3

[Joshua Cranmer [:jcranmer]]

Created attachment 8475683 [details] [diff] [review]
Install from mozbase

Note to self: hg qref *before* uploading.

Comment 4

[Mark Banner (:standard8) (afk 15 - 18 Oct)]

Comment on attachment 8475683 [details] [diff] [review]
Install from mozbase

Review of attachment 8475683 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'm happy to put a patch up for the buildbot changes, I'll try and get to it in the next day or two, depending on when I get time to try a full run locally.

Comment 5

[Joshua Cranmer [:jcranmer]]

I've pushed the changeset to comm-central:
https://hg.mozilla.org/comm-central/rev/db0269c8f5d3

Keeping this bug open until the buildbot changes happen as well.

Comment 6

[Mark Banner (:standard8) (afk 15 - 18 Oct)]

Buildbot changes have happened, this is fixed now.