Closed
Bug 1055926
Opened 7 years ago
Closed 7 years ago
Mozmill tests don't run due to no mozinfo
Categories
(Thunderbird :: Testing Infrastructure, defect)
Thunderbird
Testing Infrastructure
Tracking
(thunderbird34 fixed)
RESOLVED
FIXED
Thunderbird 34.0
Tracking | Status | |
---|---|---|
thunderbird34 | --- | fixed |
People
(Reporter: jcranmer, Assigned: jcranmer)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
3.90 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
I have a simple solution to this, which is to import mozinfo and mozfile (a mozmill dependency) directly into the virtualenv from a mozbase location. This requires a buildbot config change, though. :-(
Assignee | ||
Comment 1•7 years ago
|
||
The obvious person to review this patch would be the person who's away for another 6 days. I'm going to ask Callek to review this patch if he feels comfortable doing so, but I totally understand him not being comfortable. Another issue that is beyond my personal ability is that this changes the call to installmozmill, which at present requires a buildbot change as well: <http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4975>. If this is going to involve a complicated buildbot change, it may be worth just spending the effort on bug 1054308 instead.
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #8475679 -
Flags: review?(standard8)
Attachment #8475679 -
Flags: review?(bugspam.Callek)
Updated•7 years ago
|
Attachment #8475679 -
Flags: feedback+
Assignee | ||
Comment 2•7 years ago
|
||
FWIW, the command line this would need would appear to be python resources/installmozbuild.py MOZMILL_VIRTUALENV_DIR ../mozbase [since CWD is $TEST_UNPACK_DIR/mozmill, and mozbase is in $TEST_UNPACK_DIR/mozbase]
Assignee | ||
Comment 3•7 years ago
|
||
Note to self: hg qref *before* uploading.
Attachment #8475679 -
Attachment is obsolete: true
Attachment #8475679 -
Flags: review?(standard8)
Attachment #8475679 -
Flags: review?(bugspam.Callek)
Attachment #8475683 -
Flags: review?(standard8)
Attachment #8475683 -
Flags: review?(bugspam.Callek)
Updated•7 years ago
|
Comment 4•7 years ago
|
||
Comment on attachment 8475683 [details] [diff] [review] Install from mozbase Review of attachment 8475683 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. I'm happy to put a patch up for the buildbot changes, I'll try and get to it in the next day or two, depending on when I get time to try a full run locally.
Attachment #8475683 -
Flags: review?(standard8)
Attachment #8475683 -
Flags: review?(bugspam.Callek)
Attachment #8475683 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
I've pushed the changeset to comm-central: https://hg.mozilla.org/comm-central/rev/db0269c8f5d3 Keeping this bug open until the buildbot changes happen as well.
Target Milestone: --- → Thunderbird 34.0
Comment 6•7 years ago
|
||
Buildbot changes have happened, this is fixed now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
status-thunderbird34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•