Status
()
People
(Reporter: kinetik, Assigned: kinetik)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments)
|
974 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
|
1.89 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
There are a couple of logging niggles in content/media that are bugging me. Patches coming up.
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 8475744 [details] [diff] [review] Fix logging in AudioSink. SINK_LOG{,V} has an implicit 'this', but one place was still passing 'this' explicitly.
Attachment #8475744 -
Flags: review?(cpearce)
|
|
(Assignee) | |
Comment 2•5 years ago
|
||
Created attachment 8475745 [details] [diff] [review] Log "discarding video frame" message only when we discard frames. This confuses me every time I see it until I remember that it's lying.
Attachment #8475745 -
Flags: review?(cpearce)
|
||
Updated•5 years ago
|
Attachment #8475744 -
Flags: review?(cpearce) → review+
|
|
||
Comment 3•5 years ago
|
||
Comment on attachment 8475745 [details] [diff] [review] Log "discarding video frame" message only when we discard frames. Review of attachment 8475745 [details] [diff] [review]: ----------------------------------------------------------------- d'oh.
Attachment #8475745 -
Flags: review?(cpearce) → review+
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cdc7c7332a9 https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0190cb96ad
|
||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5cdc7c7332a9 https://hg.mozilla.org/mozilla-central/rev/2d0190cb96ad
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•5 years ago
|
Flags: qe-verify-
|
|
(Assignee) | |
Comment 6•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef35d18f71
|
|
(Assignee) | |
Comment 7•5 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #6) > https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef35d18f71 Somehow clock_time got lost in the log message, this changeset adds it.
You need to log in
before you can comment on or make changes to this bug.
Description
•