Closed Bug 1055967 Opened 6 years ago Closed 6 years ago

Fix some logging niggles in content/media

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: kinetik, Assigned: kinetik)

Details

Attachments

(2 files)

Fix logging in AudioSink. SINK_LOG{,V} has an implicit 'this', but one place was still passing 'this' explicitly.
974 bytes, patch
cpearce
: review+
Details | Diff | Splinter Review
Log "discarding video frame" message only when we discard frames.
1.89 KB, patch
cpearce
: review+
Details | Diff | Splinter Review 
There are a couple of logging niggles in content/media that are bugging me.  Patches coming up.
This confuses me every time I see it until I remember that it's lying.
Attachment #8475745 - Flags: review?(cpearce)
Attachment #8475744 - Flags: review?(cpearce) → review+
Comment on attachment 8475745 [details] [diff] [review]
Log "discarding video frame" message only when we discard frames.

Review of attachment 8475745 [details] [diff] [review]:
-----------------------------------------------------------------

d'oh.
Attachment #8475745 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/5cdc7c7332a9
https://hg.mozilla.org/mozilla-central/rev/2d0190cb96ad
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
(In reply to Matthew Gregan [:kinetik] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef35d18f71

Somehow clock_time got lost in the log message, this changeset adds it.
You need to log in before you can comment on or make changes to this bug.