1055967 - Fix some logging niggles in content/media

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

There are a couple of logging niggles in content/media that are bugging me.  Patches coming up.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Fix logging in AudioSink. SINK_LOG{,V} has an implicit 'this', but one place was still passing 'this' explicitly.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Log "discarding video frame" message only when we discard frames.

This confuses me every time I see it until I remember that it's lying.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8475745 [details] [diff] [review]
Log "discarding video frame" message only when we discard frames.

Review of attachment 8475745 [details] [diff] [review]:
-----------------------------------------------------------------

d'oh.

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cdc7c7332a9
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0190cb96ad

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5cdc7c7332a9
https://hg.mozilla.org/mozilla-central/rev/2d0190cb96ad

Comment 6

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef35d18f71

Comment 7

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef35d18f71

Somehow clock_time got lost in the log message, this changeset adds it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15ef35d18f71