1056028 - crash in OnChildProcessDumpRequested

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[Dragana Damjanovic [:dragana]]

Attachment: fix v1

Testing a pack locally a crash happened in OnChildProcessDumpRequested()
It tried to look a Mutex lock that is already destroyed and set o nullptr.

I was running mochitest with --e10s

Attached is the fix.

Comment 1

[(not currently active) Ted Mielczarek]

Thanks for the patch! This feels kind of like a wallpaper fix, we shouldn't be hitting this situation. What tests were you running?

Comment 2

[Dragana Damjanovic [:dragana]]

I am running mochitest:
./dom/media/tests/mochitest/test_peerConnection_basicH264Video.html

with --e10s

Comment 3

[(not currently active) Ted Mielczarek]

I suspect this is just a result of trying to use a nested plugin process and not having OOP crash reporting initialized in the content process. As bsmedberg said in bug 820716 comment 71 we should probably just not initialize crash reporting for plugin processes in that configuration.