1056033 - Selection broken if a new tab is appended into hidden <tabbox>

Status: NEW

(Core :: XUL, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

DevTools are using <tabbox> to implement side panel box and this tabbox can be hidden (using CSS, display: none) if necessary.

In case the tabbox is hidden and new tab is appended and immediately selected, it isn't possible to select the tab since the select="true" attribute is never set. It looks like the tab binding's "<tab>._selected" method is never called even if:
`tab._selected = true;` line is clearly executed.

Looks like the binding be broken?

STR:

1) Install the attached following extension (tested with Nightly) or download the source code from:
https://github.com/firebug/extension-examples/tree/master/ToolSideBar
2) Launch Firefox and open DevTools (F12)
3) Select the Console panel. You should see 4 new buttons in the toolbar (Add, Remove, Show, Hide)
4) Click 'Hide' to hide the side bar area (located on the right of the Console panel)
5) Click 'Add' three times to append three tabs
6) Click 'Show' to show the side bar area again
7) Click the new tabs to select them, it doesn't work -> BUG

Try to append new tabs while the side bar area is visible, the selection works just fine.

Note that the bug is caused by this code:
https://github.com/mozilla/gecko-dev/blob/master/browser/devtools/framework/sidebar.js#L105


It causes the new tab to be selected, see:
https://github.com/mozilla/gecko-dev/blob/master/browser/devtools/framework/sidebar.js#L118

If omitted, the selection works again.


Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: toolsidebar.xpi