1056038 - Oops page on users with reviews on outdated webapp versions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Mathieu Agopian [:magopian]]

http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/8504/

There's a "few" users (128) that have reviews on outdated (soft) deleted versions of webapps. When they go on their profile page, they get a 500 "oops" page.

The issue is that there's still webapps in the database that are not cleaned (see bug 1020465), and those webapps may have soft deleted versions (versions with the "deleted" field set to 1). Those soft deleted versions are excluded by the VersionManager, so when you get all the reviews and try to display their version (only if the version is outdated), you get a "Version matching query does not exist" error.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/222

Comment 2

[Mathieu Agopian [:magopian]]

fixed in https://github.com/mozilla/olympia/commit/97826aff9ced4959f402a771476657966bb7d277

Comment 3

[Victor Carciu]

Can you please add some STRs to this bug?

Comment 4

[Mathieu Agopian [:magopian]]

I'll mark this as qa- as i don't think it's possible to reproduce this without modifying the database manually.