Closed Bug 1056050 Opened 7 years ago Closed 7 years ago

[v2.1] Update has_mobile_connection and is_cell_data_connected

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RobertC, Assigned: RobertC)

References

Details

Attachments

(1 file, 1 obsolete file)

has_mobile_connection and is_cell_data_connected from gaiatest/gaia_test.py need to be updated according to Bug 932619

At this time those 2 methods always return True.
Started adhoc run to check that this change doesn't break the tests
http://jenkins1.qa.scl3.mozilla.com/view/Flame/job/flame.mozilla-central.ui.adhoc/100/
Attachment #8475891 - Flags: review?(viorela.ioia)
Attachment #8475891 - Flags: review?(florin.strugariu)
Blocks: 1055983
Attachment #8475891 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8475891 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23084

r+
Attachment #8475891 - Flags: review?(viorela.ioia) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Yep. I'll back it out.
Reverted:
https://github.com/mozilla-b2g/gaia/commit/6ad1fcc278938f792fcad4ecf8b722c4ce9c6795

This was failing on Gaia-Try so should not have been merged.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated script to handle desktop runs.
Attachment #8475891 - Attachment is obsolete: true
Attachment #8477405 - Flags: review?(zcampbell)
Attachment #8477405 - Flags: review?(viorela.ioia)
Attachment #8477405 - Flags: review?(florin.strugariu)
Comment on attachment 8477405 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23205

r+, tests are passing on desktop b2g
Attachment #8477405 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8477405 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23205

works ok but the code could be tidier.
Attachment #8477405 - Flags: review?(zcampbell) → review-
Attachment #8477405 - Flags: review- → review?(zcampbell)
Comment on attachment 8477405 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23205

r+!
Attachment #8477405 - Flags: review?(zcampbell) → review+
Attachment #8477405 - Flags: review?(florin.strugariu)
Merged:
https://github.com/mozilla-b2g/gaia/commit/bcbfeb3bb6b3e87eea2fa32f4d58db812c18f0fd
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.