Closed Bug 1056086 Opened 10 years ago Closed 9 years ago

Vagrant: Puppet provisioning should run |manage.py collectstatic|

Categories

(Tree Management :: Treeherder, enhancement, P4)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Sylvestre, Unassigned)

Details

Attachments

(1 file)

Attached image sc.png
On my local instance, the l&f is broken. Cf screenshot
Mauro gave me the solution: python manage.py collectstatic maybe this should be added to the install documentation.
I would rather add it to the puppet provisioning if it's not there yet.
Summary: Default installation of treeherder's admin miss some CSS → Vagrant: Treeherder admin panel is missing CSS until |manage.py collectstatic| is run manually
+1 to getting puppet to do this :-)
Priority: P3 → P2
Blocks: 1072681
Blocks: 1072886
No longer blocks: 1072886
I'm presuming the correct place to add this would be here? https://github.com/mozilla/treeherder-service/blob/master/puppet/manifests/classes/dev.pp Given that update.py runs collectstatic as the first step (https://github.com/mozilla/treeherder-service/blob/41384c5b6b1ceed635661aaab24740a4dbd38fe7/deployment/update/update.py#L45), I'm presuming we don't need to set a |requires|?
Also, should dev.pp be calling |manage.py load_initial_data| and |manage.py export_project_credentials| ?
Assignee: nobody → emorley
Status: NEW → ASSIGNED
No longer blocks: 1072681
Component: Treeherder → Treeherder: Docs & Development
Assignee: emorley → nobody
Status: ASSIGNED → NEW
Summary: Vagrant: Treeherder admin panel is missing CSS until |manage.py collectstatic| is run manually → Vagrant: Puppet provisioning should run |manage.py collectstatic|
Priority: P2 → P3
Priority: P3 → P4
Now that we're using WhiteNoise this is no longer necessary, since if DEBUG is true, it automatically serves the assets from their uncollected locations - both when using runserver and gunicorn. eg: [~/src/treeherder]$ curl -I http://local.treeherder.mozilla.org/static/admin/css/base.css HTTP/1.1 200 OK Server: gunicorn/19.4.3 Last-Modified: Tue, 02 Feb 2016 15:02:11 GMT Content-Length: 14049 Content-Type: text/css; charset="utf-8" Cache-Control: public, max-age=0 Access-Control-Allow-Origin: * Accept-Ranges: bytes Date: Tue, 02 Feb 2016 18:53:34 GMT X-Varnish: 1783456793 Age: 0 Via: 1.1 varnish Connection: keep-alive [~/src/treeherder]$ curl -I http://local.treeherder.mozilla.org/static/admin/css/base.css HTTP/1.1 200 OK Server: WSGIServer/0.1 Python/2.7.11 Last-Modified: Tue, 02 Feb 2016 15:02:11 GMT Content-Length: 14049 Content-Type: text/css Accept-Ranges: bytes Date: Tue, 02 Feb 2016 18:53:50 GMT X-Varnish: 1783456794 Age: 0 Via: 1.1 varnish Connection: keep-alive
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: