Vagrant: Puppet provisioning should run |manage.py collectstatic|

RESOLVED WONTFIX

Status

Tree Management
Treeherder: Docs & Development
P4
enhancement
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: sylvestre, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8475900 [details]
sc.png

On my local instance, the l&f is broken. Cf screenshot
(Reporter)

Comment 1

4 years ago
Mauro gave me the solution:
python manage.py collectstatic

maybe this should be added to the install documentation.
I would rather add it to the puppet provisioning if it's not there yet.

Updated

4 years ago
Summary: Default installation of treeherder's admin miss some CSS → Vagrant: Treeherder admin panel is missing CSS until |manage.py collectstatic| is run manually

Comment 3

4 years ago
+1 to getting puppet to do this :-)

Updated

4 years ago
Priority: P3 → P2

Updated

4 years ago
Blocks: 1072681
(Reporter)

Updated

4 years ago
Blocks: 1072886

Updated

4 years ago
No longer blocks: 1072886

Comment 4

4 years ago
I'm presuming the correct place to add this would be here?
https://github.com/mozilla/treeherder-service/blob/master/puppet/manifests/classes/dev.pp

Given that update.py runs collectstatic as the first step (https://github.com/mozilla/treeherder-service/blob/41384c5b6b1ceed635661aaab24740a4dbd38fe7/deployment/update/update.py#L45), I'm presuming we don't need to set a |requires|?

Comment 5

4 years ago
Also, should dev.pp be calling |manage.py load_initial_data| and |manage.py export_project_credentials| ?

Updated

4 years ago
Assignee: nobody → emorley
Status: NEW → ASSIGNED

Updated

3 years ago
No longer blocks: 1072681
Component: Treeherder → Treeherder: Docs & Development

Updated

3 years ago
Assignee: emorley → nobody
Status: ASSIGNED → NEW

Updated

3 years ago
Summary: Vagrant: Treeherder admin panel is missing CSS until |manage.py collectstatic| is run manually → Vagrant: Puppet provisioning should run |manage.py collectstatic|

Updated

3 years ago
Priority: P2 → P3

Updated

3 years ago
Priority: P3 → P4

Comment 6

2 years ago
Now that we're using WhiteNoise this is no longer necessary, since if DEBUG is true, it automatically serves the assets from their uncollected locations - both when using runserver and gunicorn.

eg:

[~/src/treeherder]$ curl -I http://local.treeherder.mozilla.org/static/admin/css/base.css
HTTP/1.1 200 OK
Server: gunicorn/19.4.3
Last-Modified: Tue, 02 Feb 2016 15:02:11 GMT
Content-Length: 14049
Content-Type: text/css; charset="utf-8"
Cache-Control: public, max-age=0
Access-Control-Allow-Origin: *
Accept-Ranges: bytes
Date: Tue, 02 Feb 2016 18:53:34 GMT
X-Varnish: 1783456793
Age: 0
Via: 1.1 varnish
Connection: keep-alive

[~/src/treeherder]$ curl -I http://local.treeherder.mozilla.org/static/admin/css/base.css
HTTP/1.1 200 OK
Server: WSGIServer/0.1 Python/2.7.11
Last-Modified: Tue, 02 Feb 2016 15:02:11 GMT
Content-Length: 14049
Content-Type: text/css
Accept-Ranges: bytes
Date: Tue, 02 Feb 2016 18:53:50 GMT
X-Varnish: 1783456794
Age: 0
Via: 1.1 varnish
Connection: keep-alive
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.