1056142 - Moz2D doesn't build at the moment

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Markus Stange [:mstange]]

Attachment: hack around failures

I wanted to write a unittest for bug 1055661, but after updating my moz2d clone and executing "make check", I got lots of errors. The types of errors fell into four buckets:

 - missing mfbt files: MacroArgs.h, TypedEnumInternal.h, IntegerTypeTraits.h
 - missing lines in Makefile: DataSurfaceHelpers.cpp, DrawTarget.cpp, DrawTargetCapture.cpp, DrawTargetTiled.cpp
 - CAIRO_HAS_XLIB_SURFACE was defined even though I'm on Mac and led to linker errors for _XCreatePixmap, _XFreePixmap, _XRenderFindStandardFormat
 - some weird std::ostream linker failures that were fixed by changing the CXXFLAGS to -std=c++0x instead of -std=gnu++0x

There are so many makefiles and I have no idea which one is used in what way. Who can take care of fixing this?

I'm looking forward to a future where automated tests ensure that all this keeps working.

Comment 1

[Bas Schouten (:bas.schouten)]

(In reply to Markus Stange [:mstange] from comment #0)
> Created attachment 8475944 [details] [diff] [review]
> hack around failures
> 
> I wanted to write a unittest for bug 1055661, but after updating my moz2d
> clone and executing "make check", I got lots of errors. The types of errors
> fell into four buckets:
> 
>  - missing mfbt files: MacroArgs.h, TypedEnumInternal.h, IntegerTypeTraits.h
>  - missing lines in Makefile: DataSurfaceHelpers.cpp, DrawTarget.cpp,
> DrawTargetCapture.cpp, DrawTargetTiled.cpp
>  - CAIRO_HAS_XLIB_SURFACE was defined even though I'm on Mac and led to
> linker errors for _XCreatePixmap, _XFreePixmap, _XRenderFindStandardFormat
>  - some weird std::ostream linker failures that were fixed by changing the
> CXXFLAGS to -std=c++0x instead of -std=gnu++0x
> 
> There are so many makefiles and I have no idea which one is used in what
> way. Who can take care of fixing this?
> 
> I'm looking forward to a future where automated tests ensure that all this
> keeps working.

Ugh, we'll have to fix it, after my last merge I only verified the windows builds. I'll fix this, fwiw, the Skia guys run the Moz2D stand-alone build in their automated test suites, but we(I) don't keep an eye on them :(.

Comment 2

[Markus Stange [:mstange]]

The stand-alone Moz2D repo doesn't have a future, as far as I know, so I'm closing this bug.