Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix the ship-it test suite

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8475972 [details] [diff] [review]
0001-Fix-the-tests-document-their-usage.patch

The attached patch fixes the two broken tests + add a few lines of doc.
Attachment #8475972 - Flags: review?(bhearsum)
(Assignee)

Comment 1

3 years ago
I will fix the "amazying" typo before pushing :)
Comment on attachment 8475972 [details] [diff] [review]
0001-Fix-the-tests-document-their-usage.patch

Review of attachment 8475972 [details] [diff] [review]:
-----------------------------------------------------------------

I think Nick is already fixing the tests in bug 1055858...can you check his patch out first and see if this is still necessary?
(Assignee)

Comment 3

3 years ago
Yes, it is pretty much the same except that I am adding text for the tests + some documentations.
I will update that once he merged his.
Comment on attachment 8475972 [details] [diff] [review]
0001-Fix-the-tests-document-their-usage.patch

Removing request per previous comment.
Attachment #8475972 - Flags: review?(bhearsum)
I actually obsoleted my patch, since I took the shortest route rather than the best one for testing.
(Assignee)

Comment 6

3 years ago
Comment on attachment 8475972 [details] [diff] [review]
0001-Fix-the-tests-document-their-usage.patch

OK. Thanks for the info. Setting review on Ben then ;)
Attachment #8475972 - Flags: review?(bhearsum)
(Assignee)

Updated

3 years ago
Assignee: nobody → sledru
Attachment #8475972 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 7

3 years ago
merged:
http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=3cb9318d72eeadfbb15e87eb396c47a23dc7ef39;hp=ef347c77630cb413c49b0df3e059a1ed2a56b812
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.