Same expression (aDescriptionStart != aDescriptionStart) in uriloader/exthandler/unix/nsOSHelperAppService.cpp

RESOLVED WORKSFORME

Status

()

Firefox
File Handling
RESOLVED WORKSFORME
3 years ago
7 months ago

People

(Reporter: Jacob Acord, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

In uriloader/exthanlder/unix/nsOSHelperAppService.cpp around line 734 we have the following code:
      if (aDescriptionStart != aDescriptionStart && *aDescriptionEnd == '"') {
        --aDescriptionEnd;
      }

The expression aDescriptionStart != aDescriptionStart of course will always be false. Based on the code around in, it appears the proper expression should be aDescriptionStart != aDescriptionEnd

Updated

3 years ago
Component: Untriaged → File Handling
Product: Firefox → Core
OS: Mac OS X → Linux

Updated

a year ago
Component: File Handling → File Handling
Product: Core → Firefox
Version: Trunk → unspecified
(Reporter)

Comment 1

7 months ago
This was fixed in bug 1346859.

Updated

7 months ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.