Closed Bug 1056180 Opened 10 years ago Closed 7 years ago

Same expression (aDescriptionStart != aDescriptionStart) in uriloader/exthandler/unix/nsOSHelperAppService.cpp

Categories

(Firefox :: File Handling, defect)

Product:
Firefox
Component:
File Handling
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jmaccor1012, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

In uriloader/exthanlder/unix/nsOSHelperAppService.cpp around line 734 we have the following code:
      if (aDescriptionStart != aDescriptionStart && *aDescriptionEnd == '"') {
        --aDescriptionEnd;
      }

The expression aDescriptionStart != aDescriptionStart of course will always be false. Based on the code around in, it appears the proper expression should be aDescriptionStart != aDescriptionEnd
Component: Untriaged → File Handling
Product: Firefox → Core
OS: Mac OS X → Linux
Product: Core → Firefox
Version: Trunk → unspecified
This was fixed in bug 1346859.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.