1056226 - "Unrecoverable" app uninstall does not send manifest information to uninstall event

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Kevin Grandon :kgrandon]

This is probably fairly rare, but it can break the homescreen if it happens. We define an unrecoverable app state as the following:

// Must be pending (meaning not launchable)
app.installState === 'pending' &&
// Without any option for downloading the app
!app.downloadAvailable &&
// And not be currently applying a download
!app.readyToApplyDownload


When we call mgmt.uninstall() we do not receive manifest information for the uninstalled app. This was working prior to bug 899322 landing.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: app-uninstall.patch

Not sure why I made this change initially. Looks pretty dumb :(
Anyway, we'll catch that in tests now on the gecko side too.

Comment 2

[Marco Castelluccio [:marco]]

Comment on attachment 8476146 [details] [diff] [review]
app-uninstall.patch

Review of attachment 8476146 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/tests/test_install_multiple_apps_origin.html
@@ +86,5 @@
>    is(app2.manifestURL, manifestURL2, "App 2 manifest url is correct.");
>  
> +  navigator.mozApps.mgmt.onuninstall = function(event) {
> +    var app = event.application;
> +    dump("onuninstall event.app is " + app + "\n");

Nit: Use |info| here or remove the dump.

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/a53cafed66b9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a53cafed66b9