Closed Bug 1056285 Opened 10 years ago Closed 10 years ago

Titlebar broken in fullscreen on OS X Yosemite

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 35.0

People

(Reporter: jsbruner, Assigned: jsbruner)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached patch Fix. (obsolete) — Splinter Review
On OS X 10.10 the full screen button was removed and the green "zoom" button now acts like the full screen button. In addition though, exiting full screen is no longer accomplished with the menu bar, but by the title bar, which drops down when you mouse over the top of the screen.

Because of how we're currently handling tabs in title bar though, the margins are wrong and the title bar isn't being displayed properly.
Attached patch FixSplinter Review
This patch fixes the problem. I'll attach screenshots of the before/after in a second.
Assignee: nobody → josiah
Attachment #8476162 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8476163 - Flags: review?(richard.marti)
Attached image Before
Attached image After
Comment on attachment 8476163 [details] [diff] [review]
Fix

Review of attachment 8476163 [details] [diff] [review]:
-----------------------------------------------------------------

I can't test this but the code looks good.
Attachment #8476163 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4f47656aa273
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 35.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: