Closed Bug 1056288 Opened 8 years ago Closed 8 years ago

fix thinko in OggPacketQueue

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(2 files)

Attachment #8476170 - Flags: review?(cpearce)
Comment on attachment 8476170 [details] [diff] [review]
fix thinko in OggPacketQueue

Review of attachment 8476170 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/ogg/OggCodecState.h
@@ +68,5 @@
>    void Append(ogg_packet* aPacket);
>    ogg_packet* PopFront() { return static_cast<ogg_packet*>(nsDeque::PopFront()); }
>    ogg_packet* PeekFront() { return static_cast<ogg_packet*>(nsDeque::PeekFront()); }
>    void PushFront(ogg_packet* aPacket) { nsDeque::PushFront(aPacket); }
> +  void PushBack(ogg_packet* aPacket) { nsDeque::Push(aPacket); }

We don't actually ever call this function, AFAICT, we call Append, so you can just delete PushBack().
Attachment #8476170 - Flags: review?(cpearce) → review+
Attachment #8476200 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/b3752aaa0900
https://hg.mozilla.org/mozilla-central/rev/854dd3b3be75
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.