1056288 - fix thinko in OggPacketQueue

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Nathan Froyd [:froydnj]]

http://mxr.mozilla.orhttp://mxr.mozilla.org/mozilla-central/source/content/media/ogg/OggCodecState.h?mark=71-72#71 looks mighty suspicious.  Good thing we're not using PushBack!

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix thinko in OggPacketQueue

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8476170 [details] [diff] [review]
fix thinko in OggPacketQueue

Review of attachment 8476170 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/ogg/OggCodecState.h
@@ +68,5 @@
>    void Append(ogg_packet* aPacket);
>    ogg_packet* PopFront() { return static_cast<ogg_packet*>(nsDeque::PopFront()); }
>    ogg_packet* PeekFront() { return static_cast<ogg_packet*>(nsDeque::PeekFront()); }
>    void PushFront(ogg_packet* aPacket) { nsDeque::PushFront(aPacket); }
> +  void PushBack(ogg_packet* aPacket) { nsDeque::Push(aPacket); }

We don't actually ever call this function, AFAICT, we call Append, so you can just delete PushBack().

Comment 3

[Ralph Giles (:rillian)]

Attachment: Remove unused OggPacketQueue-PushBack

Comment 4

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3752aaa0900
https://hg.mozilla.org/integration/mozilla-inbound/rev/854dd3b3be75

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3752aaa0900
https://hg.mozilla.org/mozilla-central/rev/854dd3b3be75