Closed
Bug 1056351
Opened 10 years ago
Closed 10 years ago
Clean up signup pages on welcome.wmo
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Webmaker Graveyard
webmaker.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: akirose, Assigned: akirose)
References
Details
(Whiteboard: [landingpages] [webmakersnippet])
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8476327 -
Flags: feedback?(ricardo)
Attachment #8476327 -
Flags: feedback?(cassie)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8476327 -
Flags: feedback?(ricardo) → feedback+
Comment 2•10 years ago
|
||
Left feedback on RedPen. It's looking good! I have a couple of suggestions to make the screens a bit more tidy.
Assignee | ||
Comment 3•10 years ago
|
||
Updated the screens with Ricardo's feedback!
Comment 4•10 years ago
|
||
Comment on attachment 8476327 [details] https://redpen.io/p/hae5dd65e0c5c4bb29 Looking awesome Aki! I would make a few changes to how the text is arranged, so that the page looks like it has fewer element blocks. If that makes sense. Ping me if you want me to explain further but hopefully the redpen comments are self-explanatory.
Attachment #8476327 -
Flags: feedback?(cassie) → feedback-
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8476327 [details] https://redpen.io/p/hae5dd65e0c5c4bb29 Added some new versions based on your (and ricardo's) feedback, would love a quick second look to make sure I didn't miss anything or go too heavy-handed. in one place, i went back to the original layout instead of making the buttons vertical, I think that will be okay. (i think it's the 1024 screen)
Attachment #8476327 -
Flags: feedback- → feedback?(cassie)
Comment 6•10 years ago
|
||
Comment on attachment 8476327 [details] https://redpen.io/p/hae5dd65e0c5c4bb29 Looks better to me Aki, thanks!
Attachment #8476327 -
Flags: feedback?(cassie) → feedback+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-landing-pages https://github.com/mozilla/webmaker-landing-pages/commit/ac31706a5a9a5547843de78f98256b73a051ef38 Merge pull request #62 from gesa/1056351/signup-cleanup Fixes Bug 1056351 - Clean up signup pages on welcome.wmo
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•