1056426 - Please filter out non-public apps from the Feed

Status: RESOLVED FIXED

(Marketplace Graveyard :: Curation Tools, defect, P2)

Description

[krupa raj[:krupa]]

Connectivity: wifi
SIM used: movistar spain sim
Gaia/device: 1.4/hamachi


steps to reproduce:
1. with region set to US, find the payments apps collection
2. From the details page, start the app purchase (any of the two apps will do)


expected behavior:
App purchase is successful


actual behavior:
App purchase fails within the trusted UI with "An unexpected error occurred VERIFY_FAILED" logcat shows a JS error and a 400 BAD request

08-20 17:33:12.071 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [model] app cache miss for key test-zippy-with-me
08-20 17:33:12.071 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [buttons] Install requested for Test Zippy With Me
08-20 17:33:12.081 E/GeckoConsole( 1436): Content JS WARN at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [buttons] User data not available for Test Zippy With Me
08-20 17:33:12.081 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [buttons] Starting payment flow for Test Zippy With Me
08-20 17:33:12.091 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [payments] Initiating transaction
08-20 17:33:12.101 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [req] POSTing https://marketplace-dev.allizom.org/api/v2/webpay/prepare/?_user=---&carrier=telefonica&dev=firefoxos&device=firefoxos&lang=en-US&limit=10&region=us
08-20 17:33:12.281 E/GeckoConsole( 1436): [JavaScript Error: "TypeError: t is undefined" {file: "app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js" line: 8}]
08-20 17:33:12.281 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [req] Request failed: POST 400
08-20 17:33:12.281 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [req] Response data:  {"app":["Select a valid choice. That choice is not one of the available choices."]}
08-20 17:33:12.281 E/GeckoConsole( 1436): Content JS ERROR at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [payments] Error fetching JWT from API:  BAD REQUEST 400
08-20 17:33:12.281 E/GeckoConsole( 1436): Content JS LOG at app://packaged.marketplace-feed-dev.allizom.org/media/js/include.js:8 in u/<: [buttons] Purchase flow rejected for Test Zippy With Me

Comment 1

[Kevin Ngo [:ngoke]]

If you could, could you try doing it with the network tab open and post the POST parameters?

Comment 2

[Kevin Ngo [:ngoke]]

This is because 'test-zippy-with-me' is STATUS_NULL (not public).

As for why it's showing up on the feed...we might have to filter out non-public apps. This is probably that edge case where the app's status changed AFTER it was published on the feed.

Comment 4

[krupa raj[:krupa]]

Reusing this bug to get rid of apps which are not public from the Feed. Test Zippy With me is still listed as custom featured app.

Comment 5

[Kevin Ngo [:ngoke]]

Already have a WIP PR. https://github.com/mozilla/zamboni/pull/2435

Comment 6

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/2435