There are some missing locks in SurfaceStream, but we seem to be dodging the race conditions, since this code doesn't get much contention, usually. The fix isn't hard, though.
Created attachment 8476388 [details] [diff] [review] fix-locking
Created attachment 8476408 [details] [diff] [review] fix-locking mSurfaces is only ever used on the Producer thread, and so doesn't need a mutex.
Haha, try is very sad. I'll have to look into that tomorrow.
This is honestly barely worth looking into, unless testing with it turns up something interesting. After bug 1052234, I'll be removing SurfaceStream, so unless we find a pressing issue with it, SurfaceStream is probably good enough for the rest of its life.
You need to log in before you can comment on or make changes to this bug.