Closed Bug 1056428 Opened 10 years ago Closed 5 years ago

Fix mutex locking in SurfaceStream

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

There are some missing locks in SurfaceStream, but we seem to be dodging the race conditions, since this code doesn't get much contention, usually.

The fix isn't hard, though.
Attached patch fix-locking (obsolete) — Splinter Review
Attachment #8476388 - Flags: review?(matt.woodrow)
Depends on: 1054808
Attached patch fix-lockingSplinter Review
mSurfaces is only ever used on the Producer thread, and so doesn't need a mutex.
Attachment #8476388 - Attachment is obsolete: true
Attachment #8476388 - Flags: review?(matt.woodrow)
Attachment #8476408 - Flags: review?(matt.woodrow)
Haha, try is very sad. I'll have to look into that tomorrow.
This is honestly barely worth looking into, unless testing with it turns up something interesting.

After bug 1052234, I'll be removing SurfaceStream, so unless we find a pressing issue with it, SurfaceStream is probably good enough for the rest of its life.
Attachment #8476408 - Flags: review?(matt.woodrow)

Fixed by removing SurfaceStream.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: