Fix mutex locking in SurfaceStream

NEW
Assigned to

Status

()

Core
Graphics: Layers
4 years ago
4 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
There are some missing locks in SurfaceStream, but we seem to be dodging the race conditions, since this code doesn't get much contention, usually.

The fix isn't hard, though.
(Assignee)

Comment 1

4 years ago
Created attachment 8476388 [details] [diff] [review]
fix-locking
Attachment #8476388 - Flags: review?(matt.woodrow)
(Assignee)

Updated

4 years ago
Depends on: 1054808
(Assignee)

Comment 4

4 years ago
Created attachment 8476408 [details] [diff] [review]
fix-locking

mSurfaces is only ever used on the Producer thread, and so doesn't need a mutex.
Attachment #8476388 - Attachment is obsolete: true
Attachment #8476388 - Flags: review?(matt.woodrow)
Attachment #8476408 - Flags: review?(matt.woodrow)
(Assignee)

Comment 5

4 years ago
Haha, try is very sad. I'll have to look into that tomorrow.
(Assignee)

Comment 6

4 years ago
This is honestly barely worth looking into, unless testing with it turns up something interesting.

After bug 1052234, I'll be removing SurfaceStream, so unless we find a pressing issue with it, SurfaceStream is probably good enough for the rest of its life.
Attachment #8476408 - Flags: review?(matt.woodrow)
You need to log in before you can comment on or make changes to this bug.