Closed
Bug 1056457
Opened 9 years ago
Closed 9 years ago
[Text Selection] ###!!! ASSERTION: Bad mBatching: 'mBatching >=0',
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We hit this assertion when enable selection carets and select word by long tap.
|
Assignee | |
Comment 1•9 years ago
|
||
We don't need batch changes anymore because gaia would filter all those selection change reasons correctly.
Attachment #8476441 -
Flags: review?(roc)
Attachment #8476441 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=0e72d9eb528b
|
||
Comment 3•9 years ago
|
||
I've verified on browser that the assertion is gone after applying this patch.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Nice! Thanks Ting-Yu.
|
|
Assignee | |
Comment 5•9 years ago
|
||
ICS Mochitest-7 looks weird. Rebased and try again. Latest try run: https://tbpl.mozilla.org/?tree=Try&rev=bae889a5fb0a
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/591bf545a597
Keywords: checkin-needed
|
||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/591bf545a597
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•