Clear tile metadata when history entries are removed

RESOLVED FIXED in Firefox 33

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

unspecified
Firefox 34
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox33+ fixed, firefox34 fixed)

Details

Attachments

(1 attachment)

We need to clean up this data sometimes. Same thing we do for favicons and thumbnails.
Posted patch PatchSplinter Review
Attachment #8476459 - Flags: review?(lucasr.at.mozilla)
[Tracking Requested - why for this release]:
Comment on attachment 8476459 [details] [diff] [review]
Patch

Review of attachment 8476459 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserProvider.java
@@ +1396,5 @@
>                  + " AND " + History.URL + " IS NOT NULL"
>                  + " UNION ALL SELECT " + Bookmarks.URL
>                  + " FROM " + TABLE_BOOKMARKS
>                  + " WHERE " + Bookmarks.IS_DELETED + " = 0"
>                  + " AND " + Bookmarks.URL + " IS NOT NULL)";

This selection seems to be almost the same on all delete commands (favicons, thumbnail, metadata). Maybe just consolidate it in a utility static method somewhere? Up to you.
Attachment #8476459 - Flags: review?(lucasr.at.mozilla) → review+
Comment on attachment 8476459 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1014712
[User impact if declined]: Data is retained about sites that they visted
[Describe test coverage new/current, TBPL]: Working on some.
[Risks and why]: Pretty low risk. Privacy leak if we don't do this. No great alternative beyond backing out the feature.
[String/UUID change made/needed]: None.
Attachment #8476459 - Flags: approval-mozilla-aurora?
Assignee: nobody → wjohnston
https://hg.mozilla.org/mozilla-central/rev/4de1c030dd85
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8476459 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1134479
No longer depends on: 1134479
You need to log in before you can comment on or make changes to this bug.