1056468 - Clear tile metadata when history entries are removed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We need to clean up this data sometimes. Same thing we do for favicons and thumbnails.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 2

[Wesley Johnston (:wesj)]

[Tracking Requested - why for this release]:

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8476459 [details] [diff] [review]
Patch

Review of attachment 8476459 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserProvider.java
@@ +1396,5 @@
>                  + " AND " + History.URL + " IS NOT NULL"
>                  + " UNION ALL SELECT " + Bookmarks.URL
>                  + " FROM " + TABLE_BOOKMARKS
>                  + " WHERE " + Bookmarks.IS_DELETED + " = 0"
>                  + " AND " + Bookmarks.URL + " IS NOT NULL)";

This selection seems to be almost the same on all delete commands (favicons, thumbnail, metadata). Maybe just consolidate it in a utility static method somewhere? Up to you.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/4de1c030dd85

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8476459 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1014712
[User impact if declined]: Data is retained about sites that they visted
[Describe test coverage new/current, TBPL]: Working on some.
[Risks and why]: Pretty low risk. Privacy leak if we don't do this. No great alternative beyond backing out the feature.
[String/UUID change made/needed]: None.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4de1c030dd85

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/627cec77e8a6