[Refactoring] Ril worker: set |mmiServiceCode| in one place

RESOLVED FIXED in 2.1 S3 (29aug)

Status

Firefox OS
RIL
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

unspecified
2.1 S3 (29aug)
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

4 years ago
1. Set |mmiServiceCode| in one place
2. If the string passed into sendMMI could not be correctly parsed, simply return error. This kind of the string will be treated as phone number after unifying dial and sendMMI. We don't have to handle it as ussd.
(Assignee)

Comment 1

4 years ago
Created attachment 8476498 [details] [diff] [review]
Set mmiServiceCode in one place
Attachment #8476498 - Flags: review?(htsai)
Comment on attachment 8476498 [details] [diff] [review]
Set mmiServiceCode in one place

Review of attachment 8476498 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ -2584,5 @@
>  
> -    // If we couldn't parse the MMI code, we'll send it as an USSD request.
> -    if (mmi === null) {
> -      if (this._ussdSession) {
> -        if (!_isRadioAvailable(MMI_KS_SC_USSD)) {

If I understand spec 22.030 correctly, according to clause 6.5.3 "if the network has initiated an operation which explicitly (in the signalling) requires a response from the user, then the
user shall be able to enter a response in the form of any string of characters followed by SEND. The mobile shall also
provide an MMI command to terminate the dialogue with a NULL response. " we cannot remove this.
Attachment #8476498 - Flags: review?(htsai)
(Assignee)

Comment 3

4 years ago
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> Comment on attachment 8476498 [details] [diff] [review]
> Set mmiServiceCode in one place
> 
> Review of attachment 8476498 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_worker.js
> @@ -2584,5 @@
> >  
> > -    // If we couldn't parse the MMI code, we'll send it as an USSD request.
> > -    if (mmi === null) {
> > -      if (this._ussdSession) {
> > -        if (!_isRadioAvailable(MMI_KS_SC_USSD)) {
> 
> If I understand spec 22.030 correctly, according to clause 6.5.3 "if the
> network has initiated an operation which explicitly (in the signalling)
> requires a response from the user, then the
> user shall be able to enter a response in the form of any string of
> characters followed by SEND. The mobile shall also
> provide an MMI command to terminate the dialogue with a NULL response. " we
> cannot remove this.

You are right. Cannot remove it now. We could only remove it after ussdSession.send() is introduced.
(Assignee)

Comment 4

4 years ago
Created attachment 8476558 [details] [diff] [review]
#2 Set mmiServiceCode in one place
Attachment #8476498 - Attachment is obsolete: true
Attachment #8476558 - Flags: review?(htsai)
Comment on attachment 8476558 [details] [diff] [review]
#2 Set mmiServiceCode in one place

Review of attachment 8476558 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +2632,5 @@
>          this.sendUSSD(options);
>          return;
>        }
>  
> +      _sendMMIError();

I guess you want | _sendMMIError(MMI_ERROR_KS_ERROR);|?
Attachment #8476558 - Flags: review?(htsai) → review+
(Assignee)

Comment 6

4 years ago
Created attachment 8477223 [details] [diff] [review]
#3 Set mmiServiceCode in one place. r=hsinyi

Just added some changes. Request the review again. Thx.
Attachment #8476558 - Attachment is obsolete: true
Attachment #8477223 - Flags: review?(htsai)

Updated

4 years ago
Attachment #8477223 - Flags: review?(htsai) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 8477326 [details] [diff] [review]
[final] Set mmiServiceCode in one place. r=hsinyi
Attachment #8477223 - Attachment is obsolete: true
Attachment #8477326 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f319938c2e37
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.