Closed Bug 1056534 Opened 6 years ago Closed 6 years ago

Add logging to stubbed out member functions to speed up debugging

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This is ugly in places, but we'll remove it again once we feel we've got decent implementation coverage.

There's a couple of parts to this:
- Move BufferDecoder back to webaudio/ and revert any chances made for SubBufferDecoder
- Rename SubBufferDecoder to SourceBufferDecoder
- Base SourceBufferDecoder on AbstractMediaDecoder directly, and insert logging into any stubbed member functions
- Add some ugly logging into the many stub member functions on MediaSourceResource and SourceBufferResource

It's possible some of the newly added log messages will be too verbose and will need to be removed soon.  The point of the logging is to catch the infrequently called functions that cause difficult to track down bugs.
Attachment #8476507 - Flags: review?(cajbir.bugzilla)
Blocks: MSE
Comment on attachment 8476507 [details] [diff] [review]
Add logging to stubbed out member functions to speed up debugging.

Review of attachment 8476507 [details] [diff] [review]:
-----------------------------------------------------------------

This is going to cause rebase pain so we should land this as soon as we can.
Attachment #8476507 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b26ca03840c1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.