Closed Bug 1056539 Opened 11 years ago Closed 11 years ago

[Bluetooth] Port bug Bug 1053804 to bluetooth2

Tracking

(Not tracked)

Status:

RESOLVED FIXED

Milestone:

2.1 S4 (12sep)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Details

Attachments

(6 files, 1 obsolete file)

[01] Bug 1056539: Add Bluetooth Handsfree notifications (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 17.83 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[02] Bug 1056539: Implement Bluetooth Handsfree notifications (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 10.60 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[03] Bug 1056539: Use Bluetooth Handsfree notifications (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 4.46 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[04] Bug 1056539: Integrate runnables into Handsfree notifications (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 7.51 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[05] Bug 1056539: Cleanup Bluetooth Handsfree manager (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 16.33 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[06] Bug 1056539: Replace \|MainThreadTask\| by \|CloseScoRunnable\| (under bluetooth2/) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 6.15 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[06] Bug 1056539: Replace \|MainThreadTask\| by \|CloseScoRunnable\| (under bluetooth2/) (v2) 11 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 6.27 KB, patch	tzimmermann : review+	Details \| Diff \| Splinter Review

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Description

•

11 years ago

No description provided.

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 1

•

11 years ago

Attached patch [01] Bug 1056539: Add Bluetooth Handsfree notifications (under bluetooth2/) — Details — Splinter Review

Attachment #8482248 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 2

•

11 years ago

Attached patch [02] Bug 1056539: Implement Bluetooth Handsfree notifications (under bluetooth2/) — Details — Splinter Review

Attachment #8482249 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 3

•

11 years ago

Attached patch [03] Bug 1056539: Use Bluetooth Handsfree notifications (under bluetooth2/) — Details — Splinter Review

Attachment #8482250 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 4

•

11 years ago

Attached patch [04] Bug 1056539: Integrate runnables into Handsfree notifications (under bluetooth2/) — Details — Splinter Review

Attachment #8482251 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 5

•

11 years ago

Attached patch [05] Bug 1056539: Cleanup Bluetooth Handsfree manager (under bluetooth2/) — Details — Splinter Review

Attachment #8482253 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 6

•

11 years ago

Attached patch [06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/) (obsolete) — Details — Splinter Review

Attachment #8482254 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 7

•

11 years ago

These ported patches applied cleanly on the first try without rebasing.

Ben Tian (inactive)

Comment 8

•

11 years ago

Comment on attachment 8482248 [details] [diff] [review] [01] Bug 1056539: Add Bluetooth Handsfree notifications (under bluetooth2/) Review of attachment 8482248 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8482248 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 9

•

11 years ago

Comment on attachment 8482249 [details] [diff] [review] [02] Bug 1056539: Implement Bluetooth Handsfree notifications (under bluetooth2/) Review of attachment 8482249 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8482249 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 10

•

11 years ago

Comment on attachment 8482250 [details] [diff] [review] [03] Bug 1056539: Use Bluetooth Handsfree notifications (under bluetooth2/) Review of attachment 8482250 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8482250 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 11

•

11 years ago

Comment on attachment 8482251 [details] [diff] [review] [04] Bug 1056539: Integrate runnables into Handsfree notifications (under bluetooth2/) Review of attachment 8482251 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8482251 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 12

•

11 years ago

Comment on attachment 8482253 [details] [diff] [review] [05] Bug 1056539: Cleanup Bluetooth Handsfree manager (under bluetooth2/) Review of attachment 8482253 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8482253 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 13

•

11 years ago

Comment on attachment 8482254 [details] [diff] [review] [06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/) Review of attachment 8482254 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed. ::: dom/bluetooth2/bluedroid/hfp/BluetoothHfpManager.cpp @@ +31,5 @@ > #define MOZSETTINGS_CHANGED_ID "mozsettings-changed" > #define AUDIO_VOLUME_BT_SCO_ID "audio.volume.bt_sco" > > /** > * Dispatch task with arguments to main thread. Remove this comment since |BT_HF_DISPATCH_MAIN| is already removed.

Attachment #8482254 - Flags: review?(btian) → review+

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 14

•

11 years ago

Attached patch [06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/) (v2) — Details — Splinter Review

Changes since v1: - remove outdated comment

Attachment #8482254 - Attachment is obsolete: true

Attachment #8482773 - Flags: review+

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 15

•

11 years ago

Thanks Ben! https://hg.mozilla.org/integration/b2g-inbound/rev/c8aa661283f1 https://hg.mozilla.org/integration/b2g-inbound/rev/bb709e9894be https://hg.mozilla.org/integration/b2g-inbound/rev/fd9f7f36cdeb https://hg.mozilla.org/integration/b2g-inbound/rev/7cb5a89f45f6 https://hg.mozilla.org/integration/b2g-inbound/rev/1674dc1aeebc https://hg.mozilla.org/integration/b2g-inbound/rev/ecac3d170dc8 https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=ecac3d170dc8

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 16

•

11 years ago

https://hg.mozilla.org/mozilla-central/rev/c8aa661283f1 https://hg.mozilla.org/mozilla-central/rev/bb709e9894be https://hg.mozilla.org/mozilla-central/rev/fd9f7f36cdeb https://hg.mozilla.org/mozilla-central/rev/7cb5a89f45f6 https://hg.mozilla.org/mozilla-central/rev/1674dc1aeebc https://hg.mozilla.org/mozilla-central/rev/ecac3d170dc8

Status: ASSIGNED → RESOLVED

Closed: 11 years ago

Resolution: --- → FIXED

Target Milestone: --- → 2.1 S4 (12sep)

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[Bluetooth] Port bug Bug 1053804 to bluetooth2

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Tracking

(Not tracked)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(6 files, 1 obsolete file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Comment 11

Comment 12

Comment 13

Comment 14

Comment 15

Comment 16

Attachment

General

Description

File Name

Content Type