[Bluetooth] Port bug Bug 1053804 to bluetooth2

RESOLVED FIXED in 2.1 S4 (12sep)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.1 S4 (12sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8482248 [details] [diff] [review]
[01] Bug 1056539: Add Bluetooth Handsfree notifications (under bluetooth2/)
Attachment #8482248 - Flags: review?(btian)
Created attachment 8482249 [details] [diff] [review]
[02] Bug 1056539: Implement Bluetooth Handsfree notifications (under bluetooth2/)
Attachment #8482249 - Flags: review?(btian)
Created attachment 8482250 [details] [diff] [review]
[03] Bug 1056539: Use Bluetooth Handsfree notifications (under bluetooth2/)
Attachment #8482250 - Flags: review?(btian)
Created attachment 8482251 [details] [diff] [review]
[04] Bug 1056539: Integrate runnables into Handsfree notifications (under bluetooth2/)
Attachment #8482251 - Flags: review?(btian)
Created attachment 8482253 [details] [diff] [review]
[05] Bug 1056539: Cleanup Bluetooth Handsfree manager (under bluetooth2/)
Attachment #8482253 - Flags: review?(btian)
Created attachment 8482254 [details] [diff] [review]
[06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/)
Attachment #8482254 - Flags: review?(btian)
These ported patches applied cleanly on the first try without rebasing.

Comment 8

4 years ago
Comment on attachment 8482248 [details] [diff] [review]
[01] Bug 1056539: Add Bluetooth Handsfree notifications (under bluetooth2/)

Review of attachment 8482248 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8482248 - Flags: review?(btian) → review+

Comment 9

4 years ago
Comment on attachment 8482249 [details] [diff] [review]
[02] Bug 1056539: Implement Bluetooth Handsfree notifications (under bluetooth2/)

Review of attachment 8482249 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8482249 - Flags: review?(btian) → review+

Comment 10

4 years ago
Comment on attachment 8482250 [details] [diff] [review]
[03] Bug 1056539: Use Bluetooth Handsfree notifications (under bluetooth2/)

Review of attachment 8482250 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8482250 - Flags: review?(btian) → review+

Comment 11

4 years ago
Comment on attachment 8482251 [details] [diff] [review]
[04] Bug 1056539: Integrate runnables into Handsfree notifications (under bluetooth2/)

Review of attachment 8482251 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8482251 - Flags: review?(btian) → review+

Comment 12

4 years ago
Comment on attachment 8482253 [details] [diff] [review]
[05] Bug 1056539: Cleanup Bluetooth Handsfree manager (under bluetooth2/)

Review of attachment 8482253 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8482253 - Flags: review?(btian) → review+

Comment 13

4 years ago
Comment on attachment 8482254 [details] [diff] [review]
[06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/)

Review of attachment 8482254 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth2/bluedroid/hfp/BluetoothHfpManager.cpp
@@ +31,5 @@
>  #define MOZSETTINGS_CHANGED_ID               "mozsettings-changed"
>  #define AUDIO_VOLUME_BT_SCO_ID               "audio.volume.bt_sco"
>  
>  /**
>   * Dispatch task with arguments to main thread.

Remove this comment since |BT_HF_DISPATCH_MAIN| is already removed.
Attachment #8482254 - Flags: review?(btian) → review+
Created attachment 8482773 [details] [diff] [review]
[06] Bug 1056539: Replace |MainThreadTask| by |CloseScoRunnable| (under bluetooth2/) (v2)

Changes since v1:

  - remove outdated comment
Attachment #8482254 - Attachment is obsolete: true
Attachment #8482773 - Flags: review+
You need to log in before you can comment on or make changes to this bug.