Closed Bug 1056805 Opened 7 years ago Closed 7 years ago

Minor compile-time tweaks

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(2 files)

While doing some profiling for other reasons, I noticed a few minor but easy compile-time speedups. The two patches that follow appear to give a few percentage points improvement.

The first just moves an opName() call, a virtual function, into ifdef DEBUG, as it turned out to be a significant source of indirect branch mispredictions. There are other places where this happens in the codebase too. There are more similar fixes, and I will submit them after some other patches in the same areas land.
Attachment #8476671 - Flags: review?(luke)
EliminateDeadResumePoints operands can actually take a non-insignificant amount of time. This patch disables it for Odin, which doesn't have any resume points.
Attachment #8476673 - Flags: review?(luke)
Attachment #8476671 - Flags: review?(luke) → review+
Comment on attachment 8476673 [details] [diff] [review]
no-edrp-for-odin.patch

Great!
Attachment #8476673 - Flags: review?(luke) → review+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.