1056858 - [rbbz] Publishing reviews on screenshots does not work.

Status: RESOLVED WORKSFORME

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Find or create a push-based review request with an attached screenshot. Publish that review request.
2) Open the screenshot and comment on some region of it.
3) Attempt to publish the review that you've created.

ER:

Should be able to publish that review. A comment should probably appear in Bugzilla linking to the screenshot, with the comment text.

AR:

An alert comes from Review Board, saying:

"Bugzilla error: The function requires a comment argument, and that argument was not set."

Comment 1

[Gregory Szorc [:gps]]

I'm seeing a "TypeError: rsp is null" warning in my console when I attempt to upload a png file. This still seems like a legit bug.

P2 because reviewing screenshots is something we can't do easily today with Bugzilla and it is a compelling advantage of Review Board that we should entice people with.

Comment 2

[Dan Minor [:dminor]]

mconley, based on the instructions above this is working fine for me. Could you please have another look and let me know if I'm missing something when trying to reproduce it?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Answered this in IRC - this, strangely, appears to work now. WFM?

Comment 4

[Dan Minor [:dminor]]

As far as I can tell this is now working.