1056859 - UnicodeDecodeError in JarWriter when FileRegistry contains unicode strings

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Attachment: Minimal test case

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1051809#c14

After some debugging I discovered this was because I was using MozbuildObject.topobjdir as the FileFinder basedir which is unicode. Casting it to str() first fixed the issue.

The attached test case fails. Removing the 'unicode_literals' import makes it work.

Comment 1

[Gregory Szorc [:gps]]

Yay for unicode_literals catching valid string handling bugs!

You should u.encode('utf-8') instead of str(u), where u is a unicode type.

Comment 2

[Mathew Hodson]

There was a comment mentioning this bug in /python/mozbuild/mozbuild/codecoverage/packager.py
The comment was removed in bug 1605264 and that file now imports unicode_literals.
Is this still valid?

Comment 3

[Andrew Halberstadt [:ahal]]

I'm not sure, but probably not. I have no recollection of this issue and seeing as it is 5 years old, let's file a new one if it comes up again.