Closed Bug 1056953 Opened 11 years ago Closed 11 years ago

Nit: Wrap Notification Node Instead of Using HTML()

Categories

(developer.mozilla.org Graveyard :: General, defect)

Product:
developer.mozilla.org Graveyard
Component:
General
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: davidwalsh, Unassigned)

Details

(Whiteboard: [specification][type:change])

What feature should be changed? Please provide the URL of the feature if possible. ================================================================================== The discover notification feature led me to find I'm using .html() to wrap an element, when we can use DOM operations to do so. What problems would this solve? =============================== Event assignments wouldn't be released, just a bit neater code. Who would use this? =================== Everywhere it's being used now. What would users see? ===================== Same thing. What would users do? What would happen as a result? =================================================== The same as they would before. Is there anything else we should know? ====================================== Just a nit for when we get a moment.
Severity: normal → trivial
Component: General → Design / user experience
Component: Design / user experience → General
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/0145ec6c1c6b920586c12469c2e1f45e5b658c9f fix bug 1056953 - Use DOM operations to inject content instead of innerHTML https://github.com/mozilla/kuma/commit/8488a63188f0dd36494d333dc97c7068dd19f0f3 Merge pull request #2700 from darkwing/1056953-notification-wrapping fix bug 1056953 - Use DOM operations to inject content instead of innerHTML
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.