1057012 - When signing up with Persona there is no prompt to associate with existing account if one exists (and other problems).

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, defect)

Description

[Stephanie Hobson [:shobson]]

I created an profile that was only connected to GitHub. Then I logged out and signed in with Persona, I was given the prompt to create a profile I was not warned that my email address was already taken and I did not get an error message when I tried to create the profile, it just failed with no error message.

The create profile process when logging in with Persona needs to mirror that of the create profile process when logging in with any other service. They should all provide the option to change the email address, they should all check against existing accounts, they should all offer the option to connect to an existing account.

Comment 1

[Luke Crouch [:groovecoder]]

Scenario A: User with an existing GitHub Account signs in with Persona email address matching GitHub account. 
1. Prompt to connect Persona to the MDN profile.
1a. "Yes" - Connect Persona to the account and sign them in
2a. "No" - You must use a unique email address to sign up for MDN

Scenario B: User signs in with Persona email address.
1. Prompt to connect to an existing MDN profile.
1a. "Yes" - Invoke GitHub auth to connect
1b. "No" - Create new profile

Comment 3

[ComputerSherpa]

I attempted to sign in with my GitHub account and then connect it to my Persona account. After successfully signing in with GitHub, I got a screen that said "Create your MDN profile to continue". On that screen was a box that said "Have an MDN profile already? Yes, connect with my MDN profile"; I clicked that link and got a screen that asked me to sign in with either Persona or GitHub.

At this point, I'm already signed in with GitHub. I'm trying to connect my Persona account. Showing me an option to sign in with GitHub here is probably not the right choice. But I click "Sign in with Persona", type in my email address, authenticate through Google, and I get a grey Persona window that says "Error: Something went wrong. Please try again later." There's a Cancel button and a detail of "Error: Invalid signature".

I went through the whole process again and this time I didn't get the error message; instead I got a screen asking me to pick a username. (I'm assuming this is for the test account.) I pick one and it takes me to the home screen, successfully logged in. So the process works, but it's still a little rocky.

Comment 4

[Luke Crouch [:groovecoder]]

Interesting ... when you clicked "Connect with my MDN profile", do you remember exactly what URL it took you to? I can't reproduce this locally ...

Comment 5

[Stephanie Hobson [:shobson]]

I just got the Persona error locally.

Comment 6

[ComputerSherpa]

I am able to reproduce the error. Here's the URL for the error message: https://gmail.login.persona.org/authenticate/verify?openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0&openid.mode=id_res&openid.op_endpoint=https%3A%2F%2Fwww.google.com%2Faccounts%2Fo8%2Fud&openid.response_nonce=2014-09-25T04%3A24%3A49ZH5TOACJcP0O-TQ&openid.return_to=https%3A%2F%2Fgmail.login.persona.org%2Fauthenticate%2Fverify&openid.assoc_handle=1.AMlYA9XZ8K46YtmyhRqsPj6AcG34s2kIEOyN1dh1L-_bUqe6mCu9GIxUfWGpU2FI&openid.signed=op_endpoint%2Cclaimed_id%2Cidentity%2Creturn_to%2Cresponse_nonce%2Cassoc_handle%2Cns.ext1%2Cext1.mode%2Cext1.type.email%2Cext1.value.email&openid.sig=xk5bMtWLpLzN1uiPZBJKTEoPzAU%3D&openid.identity=https%3A%2F%2Fwww.google.com%2Faccounts%2Fo8%2Fid%3Fid%3DAItOawl8PCs0b-XOYnXu9SFrnpEm8Wg4LXahvZA&openid.claimed_id=https%3A%2F%2Fwww.google.com%2Faccounts%2Fo8%2Fid%3Fid%3DAItOawl8PCs0b-XOYnXu9SFrnpEm8Wg4LXahvZA&openid.ns.ext1=http%3A%2F%2Fopenid.net%2Fsrv%2Fax%2F1.0&openid.ext1.mode=fetch_response&openid.ext1.type.email=http%3A%2F%2Faxschema.org%2Fcontact%2Femail&openid.ext1.value.email=computersherpa%40gmail.com&openid.ns.ext2=http%3A%2F%2Fspecs.openid.net%2Fextensions%2Fui%2F1.0&openid.ext2.mode=popup#

Comment 7

[Eric Shepherd [:sheppy]]

I ran into this problem early on in our testing as well (ages ago, when GitHub went alpha).

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6dd40419c1efa5f568162ced8bb44af1d99be0b3
fix bug 1057012 - show connect prompt to MDN users signing in with a Persona email address matching a GitHub account

https://github.com/mozilla/kuma/commit/05abdeb06b6c3dbc45fbfad9c69b66a9e5a15e1f
bug 1057012 - delete unique email constraint

only check for verified emails to find matching accounts

https://github.com/mozilla/kuma/commit/6b7ee26246a69185513f4fb6df2c6c68e2e408ae
fix bug 1057012 - show connect prompt to MDN users signing in with a Persona email address matching a GitHub account

https://github.com/mozilla/kuma/commit/cabddc654fbad7849baf47c5af777d0917cbf316
bug 1057012 - delete unique email constraint

only check for verified emails to find matching accounts

https://github.com/mozilla/kuma/commit/1843b8964b0e8637a059c3af34754f3089a236f9
Merge pull request #2819 from groovecoder/persona-after-github-1057012

fix bug 1057012 - Persona after github