Closed Bug 1057098 Opened 5 years ago Closed 5 years ago

rename ElementRestyler::RestyleBeforePseudo/RestyleAfterPseudo

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

No description provided.
(Er, accidentally hit enter in the summary field.)

As I point out in bug 1056917 comment 1, RestyleBeforePseudo and RestyleAfterPseudo are confusingly named since they're not the main restyling path for ::before/::after; they only exist to reframe the element if we need to create a new pseudo.

They're also similar enough that they should be merged.
Er, actually, I guess there's the ordering difference that was done intentionally for performance, so they shouldn't be merged.
Comment on attachment 8477036 [details] [diff] [review]
Rename ElementRestyler::Restyle{Before,After}Pseudo to MaybeReframeFor{Before,After}Pseudo

r=me
Attachment #8477036 - Flags: review?(bzbarsky) → review+
Summary: merge and rename ElementRestyler::RestyleBeforePseudo/RestyleAfterPseudo → rename ElementRestyler::RestyleBeforePseudo/RestyleAfterPseudo
https://hg.mozilla.org/mozilla-central/rev/56c3cb543b90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.