Closed Bug 1057134 Opened 5 years ago Closed 5 years ago

After trace-malloc is removed, we can remove the VS2013 build hack

Categories

(Firefox Build System :: General, defect)

32 Branch
x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: dmajor, Assigned: njn)

References

Details

Attachments

(1 file, 1 obsolete file)

Continuing from bug 982310

(In reply to David Major [:dmajor] from comment #22)
> Tinderbox builds no longer use trace-malloc as of Bug 1013014. The hack can
> be undone if we want (though it's not really doing any harm).

(In reply to Mike Hommey [:glandium] from comment #23)
> I'm ready to bet some people are still building locally with
> --enable-trace-malloc. Until that's actually removed, it should probably
> stay.

http://hg.mozilla.org/mozilla-central/annotate/91d7659bb351/mfbt/Atomics.h#l44
I think this is what is needed here.
Attachment #8546329 - Flags: review?(dmajor)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Slightly different after updating to tip.
Attachment #8546335 - Flags: review?(dmajor)
Attachment #8546329 - Attachment is obsolete: true
Attachment #8546329 - Flags: review?(dmajor)
Comment on attachment 8546335 [details] [diff] [review]
Remove std::_Debug_message linking hack that's no longer needed

Review of attachment 8546335 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray!
Attachment #8546335 - Flags: review?(dmajor) → review+
https://hg.mozilla.org/mozilla-central/rev/4d6c57214b1d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.